1444829 - Add WebAuthn prompt icon

Status: VERIFIED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

Let's add the icon that Amin attached to bug 1430150.

Comment 1

[Phabricator Automation]

Attachment: Bug 1444829 - Add WebAuthn prompt icon r=jcj,johannh

Comment 2

[Phabricator Automation]

Comment on attachment 8958053 [details]
Bug 1444829 - Add WebAuthn prompt icon r=jcj,johannh

J.C. Jones [:jcj] has approved the revision.

https://phabricator.services.mozilla.com/D705

Comment 3

[Phabricator Automation]

Comment on attachment 8958053 [details]
Bug 1444829 - Add WebAuthn prompt icon r=jcj,johannh

Johann Hofmann [:johannh] has approved the revision.

https://phabricator.services.mozilla.com/D705

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/88e8f60724d2
Add WebAuthn prompt icon r=jcj,johannh

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/88e8f60724d2

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8958053 [details]
Bug 1444829 - Add WebAuthn prompt icon r=jcj,johannh

Approval Request Comment
[Feature/Bug causing the regression]:
[User impact if declined]: WebAuthn prompts have no icon.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: No.
[Why is the change risky/not risky?]: Adds an icon, no functional changes.
[String changes made/needed]: None.

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 8958053 [details]
Bug 1444829 - Add WebAuthn prompt icon r=jcj,johannh

icon for webauthn, beta60+

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9a8d842f8ebe

Comment 9

[Alexandru Simonca [:asimonca], Release Desktop QA]

Hi,
I have just tested this fix on Firefox Beta 60.0b5 and Nightly 61.0a1 (id: 20180321040527) and the icon is in place and the notification looks good. 
Marking this issue as verified fixed.