Closed Bug 1444880 Opened 7 years ago Closed 7 years ago

Stop including jsfriendapi.h in all binding headers

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

Binding headers now include PrototypeList.h, which uses JSJitInfo, so has to include jsfriendapi.h. But we can move those JSJitInfo uses to PrototypeList.cpp instead.
Blocks: 1444286
This way we don't include it in all the binding headers. We only need jsfriendapi.h for the static_asserts involving JSJitInfo, so we move those to PrototypeList.cpp. MozReview-Commit-ID: 7KOmbjwSBOD
Attachment #8958071 - Flags: review?(continuation)
Comment on attachment 8958071 [details] [diff] [review] Stop including jsfriendapi.h in PrototypeList.h Review of attachment 8958071 [details] [diff] [review]: ----------------------------------------------------------------- Nice.
Attachment #8958071 - Flags: review?(continuation) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ff5221031f54 Stop including jsfriendapi.h in PrototypeList.h. r=mccr8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: