Closed
Bug 1444880
Opened 7 years ago
Closed 7 years ago
Stop including jsfriendapi.h in all binding headers
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
2.44 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
Binding headers now include PrototypeList.h, which uses JSJitInfo, so has to include jsfriendapi.h.
But we can move those JSJitInfo uses to PrototypeList.cpp instead.
| Assignee | ||
Comment 1•7 years ago
|
||
This way we don't include it in all the binding headers. We only need
jsfriendapi.h for the static_asserts involving JSJitInfo, so we move those to
PrototypeList.cpp.
MozReview-Commit-ID: 7KOmbjwSBOD
Attachment #8958071 -
Flags: review?(continuation)
Comment 2•7 years ago
|
||
Comment on attachment 8958071 [details] [diff] [review]
Stop including jsfriendapi.h in PrototypeList.h
Review of attachment 8958071 [details] [diff] [review]:
-----------------------------------------------------------------
Nice.
Attachment #8958071 -
Flags: review?(continuation) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff5221031f54
Stop including jsfriendapi.h in PrototypeList.h. r=mccr8
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•