1444889 - The new performance panel doesn't specify the "java" profiler feature

Status: RESOLVED DUPLICATE of bug 1450709

(Core :: Gecko Profiler, defect, P2)

Description

[Randell Jesup [:jesup] (needinfo me)]

Currently if you capture a profile on Android, you have to manually edit out the section with the empty Main Java thread, or perf-html.io won't process it.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Randell, could you give some STR here? I got a Fennec Nightly profile without any manual steps, besides flipping devtools.performance.new-panel-enabled. Is this about local builds only?

Comment 2

[Markus Stange [:mstange]]

This section is only included in the JSON if the "java" profiler feature is enabled: https://searchfox.org/mozilla-central/rev/de5c4376b89c3603341d226a65acea12f8851ec5/tools/profiler/core/platform.cpp#1772

The new performance panel does not specify this feature when it starts the profiler.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

It was likely due to my manually invoking fennec with profiler over ADB using a command-line given to me by chen

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

OK, thanks. I'm modifying the bug title to track the work to fix the issue Markus mentions in comment 2.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

This is now fixed in bug 1450709.

Comment 6

[Julien Wajsberg [:julienw]]

(In reply to Randell Jesup [:jesup] from comment #0)
> Currently if you capture a profile on Android, you have to manually edit out
> the section with the empty Main Java thread, or perf-html.io won't process
> it.

I'm still concerned about the initial descriptions: does perf-html.io choke on some profile then? Can you share the profile file you loaded? I think there's something we should fix in perf.html.

Comment 7

[Markus Stange [:mstange]]

The Main Java thread no longer causes perf-html.io to choke on the profile because bug 1449983 fixed its format so that perf-html.io can parse it.