144492 - Installing adsubtract software crashes with QL enabled - Trunk M11A M100 N70PR1 [@ js_Lock] [@ FindConstructor]

Status: RESOLVED WONTFIX

(Core Graveyard :: QuickLaunch (AKA turbo mode), defect)

Description

[greer]

The Trunk and M1RC2 Talkback data are both showing crashes at the js_Lock 
signature. Most users commenting, mention Quick Launch, which may be unrelated. 
So please reasign as deeper analysis dictates. There are three significant user 
comments in the M1RC2 data (given below the stack trace) that may point to a 
reproducible testcase or incompatibility with third party software.

cc'ing some JS module owners so they can weigh in.
 
Stack Trace: 

         js_Lock        [d:\builds\seamonkey\mozilla\js\src\jslock.c  line 991]
         js_AtomizeString       [d:\builds\seamonkey\mozilla\js\src\jsatom.c  
line 571]
         js_Atomize     [d:\builds\seamonkey\mozilla\js\src\jsatom.c  line 652]
         JS_NewFunction [d:\builds\seamonkey\mozilla\js\src\jsapi.c  line 2753]
         XPCNativeMember::Resolve
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativeinfo.cpp  line 
147]
         DefinePropertyIfFound
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp  
line 429]
         XPC_WN_NoHelper_Resolve
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp  
line 706]
         js_LookupProperty      [d:\builds\seamonkey\mozilla\js\src\jsobj.c  
line 2286]
         js_GetProperty [d:\builds\seamonkey\mozilla\js\src\jsobj.c  line 2447]
         js_Interpret   [d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 
2576]
         js_Invoke      [d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 
806]
         js_InternalInvoke      [d:\builds\seamonkey\mozilla\js\src\jsinterp.c  
line 881]
         JS_CallFunctionValue   [d:\builds\seamonkey\mozilla\js\src\jsapi.c  
line 3426]
         nsJSContext::CallEventHandler
[d:\builds\seamonkey\mozilla\dom\src\base\nsJSEnvironment.cpp  line 1019]
         nsJSEventListener::HandleEvent
[d:\builds\seamonkey\mozilla\dom\src\events\nsJSEventListener.cpp  line 182]
         nsEventListenerManager::HandleEventSubType
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp  line 
1218]
         nsEventListenerManager::HandleEvent
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp  line 
1893]
         GlobalWindowImpl::HandleDOMEvent
[d:\builds\seamonkey\mozilla\dom\src\base\nsGlobalWindow.cpp  line 741]
         DocumentViewerImpl::Unload
[d:\builds\seamonkey\mozilla\content\base\src\nsDocumentViewer.cpp  line 1470]
         nsDocShell::FireUnloadNotification
[d:\builds\seamonkey\mozilla\docshell\base\nsDocShell.cpp  line 757]
         nsDocShell::Destroy    
[d:\builds\seamonkey\mozilla\docshell\base\nsDocShell.cpp  line
2688]
         nsWebShell::Destroy    
[d:\builds\seamonkey\mozilla\docshell\base\nsWebShell.cpp  line
1264]
         nsXULWindow::Destroy   
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsXULWindow.cpp
line 396]
         nsWebShellWindow::Destroy
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsWebShellWindow.cpp  line 1740]
         nsWebShellWindow::Close
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsWebShellWindow.cpp  line 388]
         nsWebShellWindow::HandleEvent
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsWebShellWindow.cpp  line 466]
         nsWindow::DispatchEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 869]
         nsWindow::DispatchWindowEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 886]
         nsWindow::DispatchStandardEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 907]
         nsWindow::ProcessMessage
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 3334]
         nsWindow::WindowProc   
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line
1131]
         USER32.dll + 0x3a5f (0x77d43a5f)
         USER32.dll + 0x3b2e (0x77d43b2e)
         USER32.dll + 0x5874 (0x77d45874)
         USER32.dll + 0x58a4 (0x77d458a4)
         ntdll.dll + 0x108f (0x77f5108f)
         USER32.dll + 0x6f59 (0x77d46f59)
         nsAppShell::Run        
[d:\builds\seamonkey\mozilla\widget\src\windows\nsAppShell.cpp
line 130]
         nsAppShellService::Run
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsAppShellService.cpp  line 451]
         main1  [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp  
line 1473]
         main   [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp  
line 1809]
         WinMain        
[d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp  line 1827]
         WinMainCRTStartup()
         kernel32.dll + 0x1eb69 (0x77e7eb69)
 
        Source File : 
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/js/src/jslock.c line :
991
     (6193872)  Comments: Trying to get Mozilla-Mail into Windowstray by using 
"trayit!"
     (6188736)  Comments: when starting with quick launch and using adsubtract 
(a localhost proxy). quick launch starts before adsubtract (which is starting 
from startup group). when navigator is launched  it crashes (killing quick 
launch). once quick launch is dead and adsubtract is loaded  navigator may be 
run normally  and quick lauch will work normally for that login. this means that 
quick launch cannot be used when using adsubtract (or presumably  many other 
localhost proxies ... what about foreign host proxies what may not be there on 
startup?)
     (6166716)  Comments: Downloaded and installed software package. Black Ice 
does a scan of systemfile time/date as part of install process. Mozilla opened a 
little empty window  I closed this and Mozilla crashed. Hard to say if it was 
todo with the webpage  or to do with installing the firewall software. Cheers

Comment 1

[greer]

Attachment: Trunk and M1RC1 comments

Comment 2

[Peter Trudelle]

Grace, can you reproduce this?

Comment 3

[Grace Bush]

I have not been able to reproduce - I also have virus software and a popup
killer running which don't seem to interfere (other than to slow down
installs-but not QuickLaunch) 

Comment 4

[Samir Gehani]

Nav triage team: nsbeta1+, adt3 rtm

Comment 5

[Samir Gehani]

Nav triage team: nsbeta1-

Comment 6

[greer]

Attachment: Stack and comments

This one continues to brazenly show up in the topcrash reports for the recent
releases.

The causes continue to be wildly varied, however, we have still gotten a couple
of comments pertaining to AdSubtract software. That might be a possible avenue
to repro this bug.

Comment 7

[greer]

Reassigning -> brendan (based on blame) in hopes the he might have an idea of
where to take this one.

The immediate context of the crashing signature is:

984 JS_INLINE void
985 js_Lock(JSThinLock *tl, jsword me)
986 {
987     JS_ASSERT(me == CurrentThreadId());
988     if (js_CompareAndSwap(&tl->owner, 0, me))
989         return;
990     if (Thin_RemoveWait(ReadWord(tl->owner)) != me)
991         js_Enqueue(tl, me);
992 #ifdef DEBUG
993     else
994         JS_ASSERT(0);
995 #endif
996 }

Granted that may not be the real problem, but it's a start.

Comment 8

[Brendan Eich [:brendan]]

Please -- cvs blame on the crash frame won't tell you who is to blame, and this
is not a JS bug.  It's a shutdown ordering or similar quicklaunch-related bug,
so it should go to the QuickLaunch component owner.

/be

Comment 9

[Jay Patel [:jay]]

Since we haven't gotten anywhere with this one we'll have to wait for some
Mozilla 1.1 Beta Talkback data to see if we can get some more user comments/urls
to help us reproduce this.  

This crash has appeared in every major release/milestone, but since there might
be a few different crashes being reported under the js_Lock stack signature, we
need to find individual testcases and focus on them one at a time.

So far, most comments have mentioned the following scenerio:
1. Starting with QuickLaunch
2. Using AdSubtract software to block popup ads

Can QA try installing the AdSubtract software and see if they can reproduce this
with Mozilla 1.0 and recent Gecko1.0 and MozillaTrunk builds?

Comment 10

[Grace Bush]

downloaded adsubtract eval copy and when loading its icon into systray, machv
with QL on crashed....no talkback, was running a recommended setup type, will
try with full setup type

Comment 11

[Grace Bush]

uninstalled adsubtract and reinstalled with a full installaton of MachV- QL was
running during adsubtract install (also had 4.x running)
The adsubtract install closes browsers and it closed 4.x, MachV (the QL warning
came up that should on file/exit) and then Mach V crashed.

With adsubtract running, I installed the branch build for today- with QL and
have been running without any crashes about 4 hours.
Adding stack trace Incident ID 8475790

FindConstructor [d:\builds\seamonkey\mozilla\js\src\jsobj.c, line 1728]
GetClassPrototype [d:\builds\seamonkey\mozilla\js\src\jsobj.c, line 3237]
js_NewObject [d:\builds\seamonkey\mozilla\js\src\jsobj.c, line 1640]
js_NewFunction [d:\builds\seamonkey\mozilla\js\src\jsfun.c, line 1915]
JS_NewFunction [d:\builds\seamonkey\mozilla\js\src\jsapi.c, line 2757]
XPCNativeMember::Resolve
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativeinfo.cpp, line
147]
DefinePropertyIfFound
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp,
line 429]
XPC_WN_ModsAllowed_Proto_Resolve
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp,
line 1401]
js_LookupProperty [d:\builds\seamonkey\mozilla\js\src\jsobj.c, line 2295]
js_GetProperty [d:\builds\seamonkey\mozilla\js\src\jsobj.c, line 2456]
js_Interpret [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 2576]
js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 806]
js_InternalInvoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 881]
JS_CallFunctionValue [d:\builds\seamonkey\mozilla\js\src\jsapi.c, line 3430]
nsJSContext::CallEventHandler
[d:\builds\seamonkey\mozilla\dom\src\base\nsJSEnvironment.cpp, line 1019]
GlobalWindowImpl::RunTimeout
[d:\builds\seamonkey\mozilla\dom\src\base\nsGlobalWindow.cpp, line 4437]
GlobalWindowImpl::TimerCallback
[d:\builds\seamonkey\mozilla\dom\src\base\nsGlobalWindow.cpp, line 4784]
nsTimerImpl::Fire [d:\builds\seamonkey\mozilla\xpcom\threads\nsTimerImpl.cpp,
line 345]
nsTimerManager::FireNextIdleTimer
[d:\builds\seamonkey\mozilla\xpcom\threads\nsTimerImpl.cpp, line 593]
nsAppShell::GetNativeEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsAppShell.cpp, line 190]
nsXULWindow::ShowModal
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsXULWindow.cpp, line 279]
nsWebShellWindow::ShowModal
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsWebShellWindow.cpp, line 1108]
nsContentTreeOwner::ShowAsModal
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsContentTreeOwner.cpp, line 450]
nsWindowWatcher::OpenWindowJS
[d:\builds\seamonkey\mozilla\embedding\components\windowwatcher\src\nsWindowWatcher.cpp,
line 709]
nsWindowWatcher::OpenWindow
[d:\builds\seamonkey\mozilla\embedding\components\windowwatcher\src\nsWindowWatcher.cpp,
line 456]
GlobalWindowImpl::OpenInternal
[d:\builds\seamonkey\mozilla\dom\src\base\nsGlobalWindow.cpp, line 4087]
GlobalWindowImpl::OpenDialog
[d:\builds\seamonkey\mozilla\dom\src\base\nsGlobalWindow.cpp, line 2884]
nsNativeAppSupportWin::OnLastWindowClosing
[d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsNativeAppSupportWin.cpp, line 2563]
nsAppShellService::UnregisterTopLevelWindow
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsAppShellService.cpp, line 910]
nsXULWindow::Destroy
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsXULWindow.cpp, line 348]
nsWebShellWindow::Destroy
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsWebShellWindow.cpp, line 1763]
nsWebShellWindow::Close
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsWebShellWindow.cpp, line 388]
nsWebShellWindow::HandleEvent
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsWebShellWindow.cpp, line 485]
nsWindow::DispatchEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 1033]
nsWindow::DispatchWindowEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 1050]
nsWindow::DispatchStandardEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 1071]
nsWindow::ProcessMessage
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 3586]
nsWindow::WindowProc
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 1295]
USER32.dll + 0x1303 (0x77e71303)
USER32.dll + 0x1962 (0x77e71962)
ntdll.dll + 0x163ef (0x77f763ef)
USER32.dll + 0x1a89 (0x77e71a89)
nsAppShell::Run [d:\builds\seamonkey\mozilla\widget\src\windows\nsAppShell.cpp,
line 130]
nsAppShellService::Run
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsAppShellService.cpp, line 458]
main1 [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp, line 1483]
main [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp, line 1830]
WinMain [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp, line 1848]
WinMainCRTStartup()
KERNEL32.dll + 0x1b9ea (0x77f1b9ea) 

Comment 12

[Jay Patel [:jay]]

It looks like Grace found a way to reproduce this with yesterday's Gecko1.0
Branch build.  Adding [@ FindConstructor] to summary since that is the stack
signature she crashes with.  Also making this topcrash+ and adding testcase keyword.

Comment 13

[Jaime Rodriguez, Jr.]

renominating for nsbeta1, since grace now has a reproducible test case.

Comment 14

[chris hofmann]

If we don't nail this soon it should start making it into release notes as a
possible incompatibilty with adsubtract

Comment 15

[Grace Bush]

added to release notes

Comment 16

[Samir Gehani]

Nav triage team: nsbeta1+/adt3

Comment 17

[Samir Gehani]

Nav triage team: nsbeta1-

Comment 18

[Jay Patel [:jay]]

Doesn't look like this is a major issue according to the latest MozillaTrunk
Talkback data.  Making this topcrash-.

Comment 19

[Jon Henry]

*** Bug 201269 has been marked as a duplicate of this bug. ***

Comment 20

[Matthias Versen [:Matti]]

Quicklaunch/Turbo Mode is no longer supported in Seamonkey 2 and Seamonkey1.X is in the maintenance mode (fixing only security bugs)