Closed Bug 1444943 Opened 2 years ago Closed 2 years ago

set NSS_SDB_USE_CACHE to yes if the profile is on a networked drive (linux)

Categories

(Core :: Security: PSM, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: keeler, Assigned: keeler)

References

Details

(Whiteboard: [psm-assigned])

Attachments

(1 file)

Like bug 1435376, we should attempt to determine if the profile is on a networked drive and set NSS_SDB_USE_CACHE accordingly. I'm hoping the same APIs can be used for linux/OS X but I'm not really holding my breath. We can separate the two platforms if that doesn't work.
The solution I found for linux won't directly work on OS X (but it does look very similar).
Assignee: nobody → dkeeler
Priority: P2 → P1
Summary: set NSS_SDB_USE_CACHE to yes if the profile is on a networked drive (unix) → set NSS_SDB_USE_CACHE to yes if the profile is on a networked drive (linux)
Whiteboard: [psm-backlog] → [psm-assigned]
Comment on attachment 8958612 [details]
bug 1444943 - set NSS_SDB_USE_CACHE to yes if the profile is on an nfs mount

https://reviewboard.mozilla.org/r/227522/#review233352

`NFS_SUPER_MAGIC` is a blast from the past. Geez. Anyway, LGTM, should work fine as-is. It will get somewhat uglier with OSX and FreeBSD added to the mix. I recommend that when we add another platform we do so by adding something into a util. Heaven forbid, but maybe even an NSPR method `is_path_on_nfs`?
Attachment #8958612 - Flags: review?(jjones) → review+
Comment on attachment 8958612 [details]
bug 1444943 - set NSS_SDB_USE_CACHE to yes if the profile is on an nfs mount

https://reviewboard.mozilla.org/r/227522/#review233354

::: security/manager/ssl/nsNSSComponent.cpp:1776
(Diff revision 1)
>      // We're probably running without a profile directory, so this is
>      // irrelevant.
>      return;
>    }
>  
> -  nsCOMPtr<nsILocalFileWin> profileFileWin(do_QueryInterface(profileFile));
> +  static const char* sNSS_SDB_USE_CACHE = "NSS_SDB_USE_CACHE";

The pointer itself is not const and it will take a space in static storage.

Please use an array instead:
static const char sNSS_SDB_USE_CACHE[] = "NSS_SDB_USE_CACHE";
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f418b3ab59b
set NSS_SDB_USE_CACHE to yes if the profile is on an nfs mount r=jcj
https://hg.mozilla.org/mozilla-central/rev/1f418b3ab59b
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Duplicate of this bug: 1432484
Duplicate of this bug: 1434548
See Also: → 1456888
You need to log in before you can comment on or make changes to this bug.