1444943 - set NSS_SDB_USE_CACHE to yes if the profile is on a networked drive (linux)

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Like bug 1435376, we should attempt to determine if the profile is on a networked drive and set NSS_SDB_USE_CACHE accordingly. I'm hoping the same APIs can be used for linux/OS X but I'm not really holding my breath. We can separate the two platforms if that doesn't work.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler]]

The solution I found for linux won't directly work on OS X (but it does look very similar).

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: bug 1444943 - set NSS_SDB_USE_CACHE to yes if the profile is on an nfs mount

Review commit: https://reviewboard.mozilla.org/r/227522/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227522/

Comment 3

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 8958612 [details]
bug 1444943 - set NSS_SDB_USE_CACHE to yes if the profile is on an nfs mount

https://reviewboard.mozilla.org/r/227522/#review233352

`NFS_SUPER_MAGIC` is a blast from the past. Geez. Anyway, LGTM, should work fine as-is. It will get somewhat uglier with OSX and FreeBSD added to the mix. I recommend that when we add another platform we do so by adding something into a util. Heaven forbid, but maybe even an NSPR method `is_path_on_nfs`?

Comment 4

[Masatoshi Kimura [:emk]]

Comment on attachment 8958612 [details]
bug 1444943 - set NSS_SDB_USE_CACHE to yes if the profile is on an nfs mount

https://reviewboard.mozilla.org/r/227522/#review233354

::: security/manager/ssl/nsNSSComponent.cpp:1776
(Diff revision 1)
>      // We're probably running without a profile directory, so this is
>      // irrelevant.
>      return;
>    }
>  
> -  nsCOMPtr<nsILocalFileWin> profileFileWin(do_QueryInterface(profileFile));
> +  static const char* sNSS_SDB_USE_CACHE = "NSS_SDB_USE_CACHE";

The pointer itself is not const and it will take a space in static storage.

Please use an array instead:
static const char sNSS_SDB_USE_CACHE[] = "NSS_SDB_USE_CACHE";

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8958612 [details]
bug 1444943 - set NSS_SDB_USE_CACHE to yes if the profile is on an nfs mount

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227522/diff/1-2/

Comment 6

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8958612 [details]
bug 1444943 - set NSS_SDB_USE_CACHE to yes if the profile is on an nfs mount

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227522/diff/2-3/

Comment 7

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7fb02c9bd31d0095edaec6012ae89479072d99ae
Thanks for the reviews!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f418b3ab59b
set NSS_SDB_USE_CACHE to yes if the profile is on an nfs mount r=jcj

Comment 9

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/1f418b3ab59b