1444960 - SSL tests skipped after PKCS#11 bypass removal

Status: RESOLVED FIXED

(NSS :: Test, enhancement)

Description

[Daiki Ueno [:ueno]]

Attachment: tests-ssl-normal-normal.patch

After this change:
https://hg.mozilla.org/projects/nss/diff/838c777770a0/tests/all.sh

The possible combinations of SERVER_MODE/CLIENT_MODE in ssl.sh are:

SERVER_MODE="fips" and CLIENT_MODE="normal"

or

SERVER_MODE="normal" and CLIENT_MODE="fips"

On the other hand, some tests in ssl.sh are skipped when either SERVER_MODE or CLIENT_MODE is "fips":

$ grep -A1 '"$SERVER_MODE" = "fips"' tests/ssl/ssl.sh
    if [ "$SERVER_MODE" = "fips" -o "$CLIENT_MODE" = "fips" ] ; then
          echo "$SCRIPTNAME: skipping  $testname (non-FIPS only)"
--
    if [ "$SERVER_MODE" = "fips" -o "$CLIENT_MODE" = "fips" ] ; then
          echo "$SCRIPTNAME: skipping  $testname (non-FIPS only)"
--
    if [ "$SERVER_MODE" = "fips" -o "$CLIENT_MODE" = "fips" ] ; then
          echo "$SCRIPTNAME: skipping  $testname (non-FIPS only)"
--
    if [ "$SERVER_MODE" = "fips" -o "$CLIENT_MODE" = "fips" ] ; then
        echo "$SCRIPTNAME: skipping  $testname (non-FIPS only)"

all.sh should include the case: SERVER_MODE="normal" and CLIENT_MODE="normal", to cover those cases.

Downstream report:
https://bugzilla.redhat.com/show_bug.cgi?id=1541450

Comment 1

[Kai Engert (:KaiE:)]

Comment on attachment 8958144 [details] [diff] [review]
tests-ssl-normal-normal.patch

r=kaie

normal_normal is even the default value, if the list test of tests is undefined.
  NSS_SSL_TESTS=${NSS_SSL_TESTS:-normal_normal}

It's surprising that it had been removed in the past.

Comment 2

[Daiki Ueno [:ueno]]

Landed as: https://hg.mozilla.org/projects/nss/rev/1053cc7b45a2