1444973 - Remove browser-test-overlay.xul

Assignee

Description

•

6 years ago

The overlay loads a few scripts, so hopefully we can just replace it by dynamically loading those scripts.

Currently used by:
 - mochitest boostrap
 - remote mochitests

Brendan Dahl [:bdahl]

Assignee

Updated

•

6 years ago

Depends on: 1412456

Comment hidden (mozreview-request)

On desktop use sub script loader during bootstrap instead of the overlay.
On android use a component that listens for browser windows to be created
and then use a sub script loader.

Review commit: https://reviewboard.mozilla.org/r/229178/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229178/

(not currently active) Ted Mielczarek

Updated

•

6 years ago

Attachment #8960402 - Flags: review?(ted) → review?(ahalberstadt)

(not currently active) Ted Mielczarek

Comment 2

•

6 years ago

I'm passing this review over to ahal, who I think is a more suitable reviewer these days.

Andrew Halberstadt [:ahal]

Comment 3

•

6 years ago

mozreview-review

Comment on attachment 8960402 [details]
Bug 1444973 - Remove browser-test-overlay.xul.

https://reviewboard.mozilla.org/r/229178/#review235076

Thanks, lgtm. In case you haven't already, I'd test this on all platforms/build types on try.

::: testing/mochitest/RemoteMochitestStartup.js:21
(Diff revision 1)
> +            if (win.location.href !== "chrome://browser/content/browser.xul") {
> +                return;
> +            }

If we hit this, then I think the task would timeout without errors due to the 'once' argument.

Could we at least log that something bad happened?

::: testing/mochitest/runtestsremote.py:207
(Diff revision 1)
>      def addChromeToProfile(self, options):
>          manifest = MochitestDesktop.addChromeToProfile(self, options)
>  
>          # Support Firefox (browser), SeaMonkey (navigator), and Webapp Runtime (webapp).
>          if options.flavor == 'chrome':
>              # append overlay to chrome.manifest

nit: please update this comment

Attachment #8960402 - Flags: review?(ahalberstadt) → review+

Comment hidden (mozreview-request)

Comment on attachment 8960402 [details]
Bug 1444973 - Remove browser-test-overlay.xul.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229178/diff/1-2/

Brendan Dahl [:bdahl]

Assignee

Comment 5

•

6 years ago

mozreview-review-reply

Comment on attachment 8960402 [details]
Bug 1444973 - Remove browser-test-overlay.xul.

https://reviewboard.mozilla.org/r/229178/#review235076

> If we hit this, then I think the task would timeout without errors due to the 'once' argument.
> 
> Could we at least log that something bad happened?

A "chrome-document-global-created" could be triggered by a XUL page that isn't browser.xul, though I'm not sure if any android tests actually open any other XUL windows.

Comment hidden (mozreview-request)

Comment on attachment 8960402 [details]
Bug 1444973 - Remove browser-test-overlay.xul.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229178/diff/2-3/

Andrew Halberstadt [:ahal]

Comment 7

•

6 years ago

mozreview-review-reply

Comment on attachment 8960402 [details]
Bug 1444973 - Remove browser-test-overlay.xul.

https://reviewboard.mozilla.org/r/229178/#review235076

> A "chrome-document-global-created" could be triggered by a XUL page that isn't browser.xul, though I'm not sure if any android tests actually open any other XUL windows.

Good point, overlooked the parent observer. I think this can be dropped.

Pulsebot

Comment 8

•

6 years ago

Pushed by bdahl@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/deb3484ed429
Remove browser-test-overlay.xul. r=ahal

Tiberius Oros[:tiberius_oros]

Comment 9

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/deb3484ed429

Status: NEW → RESOLVED

Closed: 6 years ago

status-firefox61: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla61

Pulsebot

Comment 10

•

6 years ago

Backout by rgurzau@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/005891e345a4
Backed out changeset deb3484ed429 for remoteautomation.py failures on Android  a=backout

Raul Gurzau (:RaulG)

Comment 11

•

6 years ago

Backed out changeset deb3484ed429 (bug 1444973) for remoteautomation.py failures on Android a=backout

Backout link: https://hg.mozilla.org/mozilla-central/rev/005891e345a4c1ecba4bb087c8717fe00b798f03

Initial push that landed on autoland: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=deb3484ed4299e580f8d5c91e99c965149c9e88f

Push that has the revision above: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=e636edf00e6fbdc3206c9df4a1548ae38b3d13fa

Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=169407456&repo=mozilla-central&lineNumber=1884

Log snippet:  
[task 2018-03-21T11:02:43.472Z] 11:02:43     INFO -  TEST-START | dom/bindings/test/test_bug1123516_maplikesetlikechrome.xul
[task 2018-03-21T11:02:43.472Z] 11:02:43     INFO -  TEST-SKIP | dom/bindings/test/test_bug1123516_maplikesetlikechrome.xul | took 1ms
[task 2018-03-21T11:02:43.472Z] 11:02:43     INFO -  Running manifest: devtools/server/socket/tests/chrome.ini
[task 2018-03-21T11:02:45.552Z] 11:02:45     INFO -  pushing /builds/worker/workspace/build/tests/mochitest/ to /mnt/sdcard/tests/chrome on device...
[task 2018-03-21T11:04:13.576Z] 11:04:13     INFO -  runtests.py | Failed to copy /builds/worker/workspace/build/tests/mochitest/hyphenation to profile
[task 2018-03-21T11:04:13.892Z] 11:04:13     INFO -  pk12util: PKCS12 IMPORT SUCCESSFUL
[task 2018-03-21T11:04:13.920Z] 11:04:13     INFO -  MochitestServer : launching [u'/builds/worker/workspace/build/hostutils/host-utils-60.0a2.en-US.linux-x86_64/xpcshell', '-g', '/builds/worker/workspace/build/hostutils/host-utils-60.0a2.en-US.linux-x86_64', '-f', '/builds/worker/workspace/build/hostutils/host-utils-60.0a2.en-US.linux-x86_64/components/httpd.js', '-e', "const _PROFILE_PATH = '/tmp/tmpCbCd5j.mozrunner'; const _SERVER_PORT = '8888'; const _SERVER_ADDR = '10.0.2.2'; const _TEST_PREFIX = undefined; const _DISPLAY_RESULTS = false;", '-f', '/builds/worker/workspace/build/tests/mochitest/server.js']
[task 2018-03-21T11:04:13.920Z] 11:04:13     INFO -  runtests.py | Server pid: 987
[task 2018-03-21T11:04:13.925Z] 11:04:13     INFO -  runtests.py | Websocket server pid: 990
[task 2018-03-21T11:04:13.937Z] 11:04:13     INFO -  runtests.py | SSL tunnel pid: 993
[task 2018-03-21T11:04:18.981Z] 11:04:18     INFO -  runtests.py | Running with e10s: False
[task 2018-03-21T11:04:18.981Z] 11:04:18     INFO -  runtests.py | Running tests: start.
[task 2018-03-21T11:04:26.126Z] 11:04:26     INFO -  INFO | automation.py | Application pid: 1976
[task 2018-03-21T11:11:17.428Z] 11:11:17     INFO -  Browser unexpectedly found running. Killing...
[task 2018-03-21T11:11:17.453Z] 11:11:17     INFO -  TEST-INFO | started process screentopng
[task 2018-03-21T11:11:17.787Z] 11:11:17     INFO -  TEST-INFO | screentopng: exit 0
[task 2018-03-21T11:11:21.882Z] 11:11:21     INFO -  org.mozilla.fennec_aurora still alive after SIGABRT: waiting...
[task 2018-03-21T11:11:27.103Z] 11:11:27  WARNING -  TEST-UNEXPECTED-FAIL | remoteautomation.py | application timed out after 370 seconds with no output
[task 2018-03-21T11:11:27.104Z] 11:11:27     INFO -  INFO | automation.py | Application ran for: 0:07:08.121941
[task 2018-03-21T11:11:27.104Z] 11:11:27     INFO -  INFO | zombiecheck | Reading PID log: /tmp/tmpUq6Mvspidlog
[task 2018-03-21T11:11:27.272Z] 11:11:27     INFO -  /data/anr/traces.txt not found
[task 2018-03-21T11:11:27.441Z] 11:11:27     INFO -  /data/tombstones does not exist; tombstone check skipped
[task 2018-03-21T11:11:28.302Z] 11:11:28     INFO -  mozcrash Downloading symbols from: https://queue.taskcluster.net/v1/task/bUaSyr8JTveFPQqspLUYQw/artifacts/public/build/target.crashreporter-symbols.zip
[task 2018-03-21T11:11:32.330Z] 11:11:32     INFO -  mozcrash Copy/paste: /usr/local/bin/linux64-minidump_stackwalk /tmp/tmptVeYdO/6ffc52d7-bdb4-4667-ea49-f84860611551.dmp /tmp/tmpTsALDn
[task 2018-03-21T11:11:39.765Z] 11:11:39     INFO -  mozcrash Saved minidump as /builds/worker/workspace/build/blobber_upload_dir/6ffc52d7-bdb4-4667-ea49-f84860611551.dmp
[task 2018-03-21T11:11:39.765Z] 11:11:39     INFO -  mozcrash Saved app info as /builds/worker/workspace/build/blobber_upload_dir/6ffc52d7-bdb4-4667-ea49-f84860611551.extra
[task 2018-03-21T11:11:39.768Z] 11:11:39  WARNING -  PROCESS-CRASH | remoteautomation.py | application crashed [@ libc.so + 0x26837]
[task 2018-03-21T11:11:39.769Z] 11:11:39     INFO -  Crash dump filename: /tmp/tmptVeYdO/6ffc52d7-bdb4-4667-ea49-f84860611551.dmp

Status: RESOLVED → REOPENED

status-firefox61: fixed → ---

Flags: needinfo?(bdahl)

Resolution: FIXED → ---

Target Milestone: mozilla61 → ---

Brendan Dahl [:bdahl]

Assignee

Comment 12

•

6 years ago

Strange, I wasn't seeing any failures on try for android.

Comment hidden (mozreview-request)

Comment on attachment 8960402 [details]
Bug 1444973 - Remove browser-test-overlay.xul.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229178/diff/3-4/

Comment hidden (mozreview-request)

Comment on attachment 8960402 [details]
Bug 1444973 - Remove browser-test-overlay.xul.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229178/diff/4-5/

Brendan Dahl [:bdahl]

Assignee

Comment 15

•

6 years ago

Comment on attachment 8960402 [details]
Bug 1444973 - Remove browser-test-overlay.xul.

Looking better now:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f462cc66f7ef53591a0f6ef284f8175cfce506ba

I don't love the way of using a manifest comment to signal to the browser that we need to load the test files, but I don't really have any better ideas.

Flags: needinfo?(bdahl)

Attachment #8960402 - Flags: review?(ahalberstadt)

Andrew Halberstadt [:ahal]

Comment 16

•

6 years ago

mozreview-review

Comment on attachment 8960402 [details]
Bug 1444973 - Remove browser-test-overlay.xul.

https://reviewboard.mozilla.org/r/229178/#review236086

::: testing/mochitest/bootstrap.js:49
(Diff revision 5)
>    return new TextDecoder().decode(buffer);
>  }
>  
>  function androidStartup(data, reason) {
> +  // Only browser chrome tests need help starting.
> +  if (readSync(data.resourceURI.resolve("chrome.manifest")).includes('MOCHITEST_CHROME')) {

I think you could check that the pref "mochitest.testRoot" ends with the string "/chrome". Alternatively, we could create a new "mochitest.flavor" pref around here:
https://searchfox.org/mozilla-central/source/testing/mochitest/runtests.py#1847

(set it to the value of options.flavor, which should be 'chrome')

::: testing/mochitest/runtestsremote.py:206
(Diff revision 5)
> -            # append overlay to chrome.manifest
> -            chrome = ("overlay chrome://browser/content/browser.xul "
> -                      "chrome://mochikit/content/browser-test-overlay.xul")
> +            # append comment to chrome.manifest to signal boostrap.js to start tests
> +            chrome = """
> +# MOCHITEST_CHROME

With the above recommendation fixed you can remove this whole function.

Attachment #8960402 - Flags: review?(ahalberstadt) → review+

Comment hidden (mozreview-request)

Comment on attachment 8960402 [details]
Bug 1444973 - Remove browser-test-overlay.xul.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/229178/diff/5-6/

Pulsebot

Comment 18

•

6 years ago

Pushed by bdahl@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/adedd212cd72
Remove browser-test-overlay.xul. r=ahal

Raul Gurzau (:RaulG)

Comment 19

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/adedd212cd72

Status: REOPENED → RESOLVED

Closed: 6 years ago → 6 years ago

status-firefox61: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla61

Kris Maglione [:kmag]

Comment 20

•

6 years ago

mozreview-review

Comment on attachment 8960402 [details]
Bug 1444973 - Remove browser-test-overlay.xul.

https://reviewboard.mozilla.org/r/229178/#review236830

::: testing/mochitest/runtestsremote.py
(Diff revision 6)
> -    def addChromeToProfile(self, options):
> -        manifest = MochitestDesktop.addChromeToProfile(self, options)
> -
> -        # Support Firefox (browser), SeaMonkey (navigator), and Webapp Runtime (webapp).
> -        if options.flavor == 'chrome':
> -            # append overlay to chrome.manifest
> -            chrome = ("overlay chrome://browser/content/browser.xul "
> -                      "chrome://mochikit/content/browser-test-overlay.xul")
> -            path = os.path.join(options.profilePath, 'extensions', 'staged',
> -                                'mochikit@mozilla.org', 'chrome.manifest')
> -            with open(path, "a") as f:
> -                f.write(chrome)
> -        return manifest

You have no idea how happy this makes me.