Closed Bug 1445031 Opened 6 years ago Closed 6 years ago

Adbeaver extension causes millions of JavaScript errors on Facebook.com per day.

Categories

(Toolkit :: Blocklist Policy Requests, defect)

Product:
Toolkit
Component:
Blocklist Policy Requests
Version:
56 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: rrh, Assigned: jorgev)

Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180312134431

Steps to reproduce:

I am working on JavaScript reliability at Facebook.com. Right now the extension  https://addons.mozilla.org/en-US/firefox/addon/adbeaver/ causes around 6M JavaScript errors per day on our site. This is due to the foxydeals.js that adbeaver uses. Error message is :"JSON.parse: unexpected character at line 1 column 1 of the JSON data" With the following stacktrace: "(html/resource://adbeaver/content/Main/foxydeal.js:3733)"

This only happens on Firefox, primarily in the Philippines, Indonesia, US and Spain with several other countries long tailing off. Mostly on version 56, then 52, then a bunch of 30s and 40s version.

We'd like this error fixed by the developer if possible, but barring that, blacklisted.

Thanks in advance!


Actual results:

This extension throws an error


Expected results:

It doesn't throw an error.
The developers have been notified. We will give them 2 weeks to respond.
Assignee: nobody → jorge
Status: UNCONFIRMED → NEW
Ever confirmed: true
Mathieu, I don't know if Philipp contacted you about this, but there's a problem with add-on blocklist requests that isn't allowing me to submit them for review. I just staged one and there's no way to request review for it anymore. Can you look into this?
Flags: needinfo?(mathieu)
Thanks, we are aware of the problem and very sorry that it blocks you too (see Bug 1448157) 

The workaround is to use the command-line while we find a fix and redeploy a new version.

Using curl, to request review:

    curl --request PATCH https://settings-writer.prod.mozaws.net/v1/buckets/staging/collections/addons -d '{"data":{"status":"to-review"}}' -H 'Content-Type:application/json' -u 'user@mozilla.com:pass'

And similar thing to approve changes:

    curl --request PATCH https://settings-writer.prod.mozaws.net/v1/buckets/staging/collections/addons -d '{"data":{"status":"to-sign"}}' -H 'Content-Type:application/json' -u 'user@mozilla.com:pass'


We are tracking the bug upstream here as well https://github.com/Kinto/kinto-admin/issues/495
Flags: needinfo?(mathieu)
We fixed the bug upstream, released and asked to OPS to deploy. It should be rolled out soon.

In the mean time, you can use the standalone UI at https://kinto.github.io/kinto-admin/
You would just have to use Server:  ``https://settings-writer.prod.mozaws.net/v1`` and ``Basic Auth`` authentication
The block is staged. Philipp, please review and push.
Flags: needinfo?(philipp)
The block is now live.
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(philipp)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.