1445066 - Clicking "Last search results" sometimes results in an error

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Search, defect)

Description

[Mark Côté [:mcote]]

Sometimes when I'm looking at bugs from a search result, clicking on "Last search results" takes me to a page with this error:

    You may not search, or create saved searches, without any search terms. 

This happens frequently, but not always.  When I tried to deliberately reproduce it, I wasn't able to, yet it happened again just now.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Testing something...

Comment 2

[Dylan Hardison [:dylan] (he/him)]

https://bugzilla.mozilla.org/buglist.cgi?regetlastlist=
                                                       ^^^^^^^^^^^^^^
Defined here: https://github.com/mozilla-bteam/bmo/blob/e655f5133b4dd5c5d6f253069767db75c64eb349/extensions/BugModal/template/en/default/bug_modal/navigate.html.tmpl#L32

That's similar to template/en/default/bug/navigate.html.tmpl.

my_search is set here:
https://github.com/mozilla-bteam/bmo/blob/e655f5133b4dd5c5d6f253069767db75c64eb349/template/en/default/bug/navigate.html.tmpl#L46

and here:
https://github.com/mozilla-bteam/bmo/blob/e655f5133b4dd5c5d6f253069767db75c64eb349//extensions/BMO/template/en/default/hook/global/header-additional_header.html.tmpl#L29

It looks like perhaps this is a typo, because in the first file, 'search' is defined:

https://github.com/mozilla-bteam/bmo/blob/e655f5133b4dd5c5d6f253069767db75c64eb349/extensions/BugModal/template/en/default/bug_modal/navigate.html.tmpl#L11

Comment 3

[:glob ✱]

Attachment: pr