1445081 - Update Debugger Frontend v21

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Comment 1

[Jason Laster [:jlast]]

https://github.com/devtools-html/debugger.html/compare/release-20...release-21

Comment 2

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=37e9f941c986433aa3aba2b709dca5bb4a1c37ac
https://treeherder.mozilla.org/#/jobs?repo=try&revision=269d1f049d4b7929713587e6637a811c45363cf4

Comment 3

[Jason Laster [:jlast]]

Attachment: rel-21-align.patch

Comment 4

[Jason Laster [:jlast]]

Attachment: rel-21.patch

Comment 5

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=37e9f941c986433aa3aba2b709dca5bb4a1c37ac
https://treeherder.mozilla.org/#/jobs?repo=try&revision=269d1f049d4b7929713587e6637a811c45363cf4

Comment 6

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=781b45faaeaeac82086967ea9037fe2217a11494

Comment 7

[Julian Descottes [:jdescottes]]

Comment on attachment 8958641 [details] [diff] [review]
rel-21-align.patch

Review of attachment 8958641 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me but I have two questions about those "align" patches since that's the second in a row:
- what is driving the "alignment" in the bundle?
- why is there no commit associated with this?

In theory we should be able to trace back a release in m-c to a tag in GitHub and regenerate the exact same bundle from GitHub.
It seems like we can generate two completely different artifacts for a single release version?

::: devtools/client/debugger/new/README.mozilla
@@ -1,5 @@
>  This is the debugger.html project output.
>  See https://github.com/devtools-html/debugger.html
>  
> -Version 19.2
> -Comparison: https://github.com/devtools-html/debugger.html/compare/release-19-1...release-19-2

Could you redo the patch to be on top of v20.0 ?

Comment 8

[Julian Descottes [:jdescottes]]

Looks like the patch is on top of the intermediary patch for v20.0 which was missing the README update. Consequently the patches here don't apply either on inbound or on central. But for inbound the conflict is only with the README so that's manageable.

Comment 9

[Julian Descottes [:jdescottes]]

Comment on attachment 8958643 [details] [diff] [review]
rel-21.patch

Review of attachment 8958643 [details] [diff] [review]:
-----------------------------------------------------------------

- Meta:
 - assigned, P3, enhancement, blocks meta: OK
 - commit message: OK
 - less than 20 commits: OK 
- TRY
 - try run green: OK
 - try run has rebuild: OK 
- Manual test: OK
- README review: OK 
- Properties file review: OK
- New files: OK

Comment 10

[Jason Laster [:jlast]]

Attachment: rel-21-align-2.patch

Comment 11

[Jason Laster [:jlast]]

Attachment: rel-21-2.patch

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5336cf59879b
Re-align webpack module ordering. r=jdescottes
https://hg.mozilla.org/integration/mozilla-inbound/rev/bcb818464c50
Update Debugger Frontend v21. r=jdescottes

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5336cf59879b
https://hg.mozilla.org/mozilla-central/rev/bcb818464c50

Comment 14

[Julian Descottes [:jdescottes]]

Forgot to push to talos: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=cf4053113e933e08a44aec0d632ac9cac9088d57&newProject=try&newRevision=91cf8dc8ab7db1bb13f42130249d220f7ab3a172&framework=1

Comment 15

[Julian Descottes [:jdescottes]]

Early results on http://firefox-dev.tools/performance-dashboard/tools/debugger.html?days=14&filterstddev=true seem to show a noticeable perf regression from v21: 
- 4% on complicated.open
- 8% on custom.open
- 4% on custom.reload
- 3% on custom.pause
- 10% on custom close
- 5% on simple.open

(stepping tests are a bit too noisy to tell so early)