Open Bug 1445121 Opened 6 years ago Updated 1 year ago

SetEventTargetForActor called on actor that already has an event target

Categories

(Core :: IPC, defect, P2)

60 Branch
defect

Tracking

()

People

(Reporter: jld, Unassigned)

References

Details

The patch from bug 1436156 to make CHECK and DCHECK assertions in ipc/chromium work again has uncovered a regression, reproduced by running the test dom/indexedDB/test/browser_permissionsPromptAllow.js, with a crash stack:

#1  0x00007f97a19eea76 in Abort (aMsg=0x7ffce4760c98 "[Child 16165, Main Thread] ###!!! ABORT: Inserting duplicate item: file /home/jld/src/gecko-dev/ipc/chromium/src/base/id_map.h, line 60") at /home/jld/src/gecko-dev/xpcom/base/nsDebugImpl.cpp:457
#5  0x00007f97a1f00c4e in IDMap<nsCOMPtr<nsIEventTarget> >::AddWithID(nsCOMPtr<nsIEventTarget> const&, int) (this=this@entry=0x7f97b12b8110, data=..., id=id@entry=-9) at /home/jld/src/gecko-dev/ipc/chromium/src/base/id_map.h:60
#6  0x00007f97a1ef8b4b in mozilla::ipc::IToplevelProtocol::SetEventTargetForActorInternal(mozilla::ipc::IProtocol*, nsIEventTarget*) (this=0x7f97b12b8020, aActor=<optimized out>, aEventTarget=0x7f979e6de8b0) at /home/jld/src/gecko-dev/ipc/glue/ProtocolUtils.cpp:888
#7  0x00007f97a369bea0 in mozilla::dom::indexedDB::BackgroundFactoryRequestChild::RecvPermissionChallenge(mozilla::ipc::PrincipalInfo const&) (this=0x7f979f5218e0, aPrincipalInfo=...) at /home/jld/src/gecko-dev/dom/indexedDB/ActorsChild.cpp:2000

I tried investigating this but it's not clear to me whether it's SetEventTargetForActorInternal or BackgroundFactoryRequestChild (or something else) that's in error here.
Priority: -- → P2
See Also: → 1597282
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.