Closed Bug 1445352 Opened 6 years ago Closed 5 years ago

no code-coverage for (at-least?) JSX files

Categories

(Firefox :: New Tab Page, enhancement, P3)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Iteration:
68.2 - Apr 1 - 14
Tracking Flags:
Tracking Status
firefox60 --- wontfix
firefox61 --- wontfix
firefox68 --- fixed

People

(Reporter: dmosedale, Assigned: andreio)

References

Details

(Keywords: github-merged, Whiteboard: [chore])

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4866
52 bytes, text/x-github-pull-request
Details | Review 
STR:
`npm run testmc`
`npm run debugcoverage`

View the HTML coverage report, and notice that there are no JSX coverage reports generated.
https://github.com/mozilla/activity-stream/commit/fd1b60691 added code coverage and it reported only common/{Actions,Reducers}.jsm and lib/{ActivityStream,Store}.jsm being covered.

Although back then there were also no content-src tests. The first content-src test was added in https://github.com/mozilla/activity-stream/commit/d661e2df and coverage did include content-src directory but only content-src/lib/{detect-user-session-start,init-store}.js so still no jsx.
Severity: normal → enhancement
Iteration: --- → 61.2 - Apr 9
status-firefox60: --- → wontfix
status-firefox61: --- → affected
Priority: -- → P2
Iteration: 61.2 - Apr 9 → 61.3 - Apr 23
Iteration: 61.3 - Apr 23 → 61.4 - May 7
Iteration: 61.4 - May 7 → 62.1 - May 21
Priority: P2 → P3
Iteration: 62.1 - May 21 → 62.2 - Jun 4
Iteration: 62.2 - Jun 4 → 63.1 - July 9
Priority: P3 → P2
Whiteboard: [chore]
Iteration: 63.1 - July 9 → ---
Priority: P2 → P3
Assignee: nobody → andrei.br92
Blocks: 1541502

https://hg.mozilla.org/mozilla-central/rev/7a266c35cb30

Status: NEW → RESOLVED
Iteration: --- → 68.2 - Apr 1 - 14
Closed: 5 years ago
status-firefox68: --- → fixed
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: