1445377 - test_dialogfocus.xul, test_showcaret.xul, and test_menubar.xul fail on windows 10 with the new taskcluster worker

Status: RESOLVED WORKSFORME

(Toolkit :: UI Widgets, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

updating our infrastructure/tooling to fix bugs/features we have a new worker which is responsible for accepting the tests to run and launching the mozharness/test script to run the tests.

The main difference in the new worker is that we login as an actual user instead of simulating it with runas and mapping directories.

while doing this we see failures [1]:
22:24:51     INFO -  664 INFO TEST-START | toolkit/content/tests/chrome/test_dialogfocus.xul
22:24:51     INFO -  665 INFO must wait for load
22:24:51     INFO -  666 INFO We have full keyboard access
22:24:51     INFO -  667 INFO runTest(), step = 1, expected = one
22:30:02     INFO -  Not taking screenshot here: see the one that was previously logged
22:30:02    ERROR -  668 INFO TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_dialogfocus.xul | Test timed out.

we get this info statement:
https://searchfox.org/mozilla-central/source/toolkit/content/tests/chrome/test_dialogfocus.xul#54

but nothing else, I assume this is window.openDialog and we don't get focus.


and test_showcaret.xul:
22:36:02     INFO -  781 INFO must wait for load
22:36:02     INFO -  782 INFO TEST-PASS | toolkit/content/tests/chrome/test_showcaret.xul | focusNode for non-showcaret
22:36:02     INFO -  783 INFO TEST-PASS | toolkit/content/tests/chrome/test_showcaret.xul | focusOffset for non-showcaret
22:36:02     INFO -  784 INFO TEST-PASS | toolkit/content/tests/chrome/test_showcaret.xul | scrollY for showcaret
22:36:02     INFO -  785 INFO TEST-PASS | toolkit/content/tests/chrome/test_showcaret.xul | focusNode for showcaret
22:36:02     INFO -  786 INFO TEST-PASS | toolkit/content/tests/chrome/test_showcaret.xul | focusOffset for showcaret
22:36:02     INFO -  Buffered messages finished
22:36:02    ERROR -  787 INFO TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_showcaret.xul | Test timed out.
22:36:02     INFO -  reportError@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:121:7

the last ok we get is here:
https://searchfox.org/mozilla-central/source/toolkit/content/tests/chrome/test_showcaret.xul#61

then we open a window and never seem to get focus on that window.



and test_menubar.xul:
22:41:48     INFO -  928 INFO TEST-PASS | toolkit/content/tests/widgets/test_menubar.xul | Alt keydown set focus the menubar event target ID filemenu
22:41:48     INFO -  929 INFO TEST-PASS | toolkit/content/tests/widgets/test_menubar.xul | Alt keydown set focus the menubar filemenu menu is open
22:41:48     INFO -  930 INFO TEST-PASS | toolkit/content/tests/widgets/test_menubar.xul | unset focus the menubar event type DOMMenuBarInactive fired
22:41:48     INFO -  931 INFO TEST-PASS | toolkit/content/tests/widgets/test_menubar.xul | unset focus the menubar event target ID menubar
22:41:48     INFO -  932 INFO TEST-PASS | toolkit/content/tests/widgets/test_menubar.xul | unset focus the menubar event type DOMMenuItemInactive fired
22:41:48     INFO -  933 INFO TEST-PASS | toolkit/content/tests/widgets/test_menubar.xul | unset focus the menubar event target ID filemenu
22:41:48     INFO -  Buffered messages finished
22:41:48    ERROR -  934 INFO TEST-UNEXPECTED-FAIL | toolkit/content/tests/widgets/test_menubar.xul | Test timed out.
22:41:48     INFO -  reportError@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:121:7

this looks to make it here:
https://searchfox.org/mozilla-central/source/toolkit/content/tests/widgets/window_menubar.xul#779

I am not sure how that test runner works to do which steps.


[1] https://taskcluster-artifacts.net/K6qM_CD-SPaHDJEKttRh2w/0/public/logs/live_backing.log

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Neil, can you help take a look at this.  Are these tests ok to disable?  Do you have ideas on how to debug this?

It seems to be a lack of focus and I have filed a few other bugs related to this for prompts and other tests.

Comment 2

[Neil Deakin]

The common situation in all three tests is that they open a window and then wait for a focus event, but they just listen using addEventListener rather than SimpleTest.waitForFocus. Perhaps the focus event is occurring before window.open finishes? As a start, switching to waitForFocus would handle this case if true.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

I looked at:
https://searchfox.org/mozilla-central/source/toolkit/content/tests/chrome/test_dialogfocus.xul#114

and tried replacing the addEventListener with:
  SimpleTest.waitForFocus(checkDialogFocusEvent, win);


this didn't work for me locally, nor did a few variations on the above command.  Is it possible that we need the addEventListener for a reason in some of these test cases?

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

closing this bug as a fix to the generic worker resolved issues- any remaining issues with the tests are not related to the worker upgrade.