Closed Bug 1445386 Opened 2 years ago Closed 2 years ago

Artifact build scalar loading uses wrong directory on macOS

Categories

(Toolkit :: Telemetry, enhancement)

43 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

Details

Attachments

(1 file)

Bug 1425909 added a way to load new scalars for artifact builds.  However, it tries to load a file from "GreBinD", which on macOS equates to:

<objdir>/dist/Nightly.app/Contents/MacOS

while the file is actually installed to:

<objdir>/dist/Nightly.app/Contents/Resources

Using "GreD" instead gives the correct path.  (AFAIK, macOS is the only platform where these two gives different paths due to Apple's requirements about binaries vs. other files being divided up.)
Comment on attachment 8958569 [details]
Bug 1445386 - Use GreD for artifact build scalars.

https://reviewboard.mozilla.org/r/227466/#review233290

Sounds good to me.

For future people reading this, this particular quirk of GreD and GreBinD is documented in nsDirectoryServiceDefs.h
Attachment #8958569 - Flags: review?(chutten) → review+
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3df355881aa0
Use GreD for artifact build scalars. r=chutten
Sorry, didn't notice the original bug added tests...  Will update that as well.
Flags: needinfo?(jryans)
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1141d759f71a
Use GreD for artifact build scalars. r=chutten
https://hg.mozilla.org/mozilla-central/rev/1141d759f71a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.