Closed Bug 1445386 Opened 2 years ago Closed 2 years ago
Artifact build scalar loading uses wrong directory on mac
59 bytes, text/x-review-board-request
Bug 1425909 added a way to load new scalars for artifact builds. However, it tries to load a file from "GreBinD", which on macOS equates to: <objdir>/dist/Nightly.app/Contents/MacOS while the file is actually installed to: <objdir>/dist/Nightly.app/Contents/Resources Using "GreD" instead gives the correct path. (AFAIK, macOS is the only platform where these two gives different paths due to Apple's requirements about binaries vs. other files being divided up.)
Comment on attachment 8958569 [details] Bug 1445386 - Use GreD for artifact build scalars. https://reviewboard.mozilla.org/r/227466/#review233290 Sounds good to me. For future people reading this, this particular quirk of GreD and GreBinD is documented in nsDirectoryServiceDefs.h
Attachment #8958569 - Flags: review?(chutten) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/3df355881aa0 Use GreD for artifact build scalars. r=chutten
Backed out for xpcshell failures on test_TelemetryScalars_buildFaster.js Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=167755878&repo=autoland&lineNumber=7820 Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=3df355881aa04907482a7a96a84430c4ce732bd0&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified Backout link: https://hg.mozilla.org/integration/autoland/rev/d5912e36b50a0183229d1b93111c1c3fdd49e56e
Sorry, didn't notice the original bug added tests... Will update that as well.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/1141d759f71a Use GreD for artifact build scalars. r=chutten
You need to log in before you can comment on or make changes to this bug.