1445496 - Update Debugger Frontend v22

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Comment 1

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5eaf363dc45e52738a1b1a558c54053e997dba81

Comment 2

[Jason Laster [:jlast]]

release 23 try runs, because why not

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8649c0c83378279acdd4f6574453ff4d338714b0
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4966531e95e71f1d45d29dc30f75c5969d380ee

Comment 3

[Jason Laster [:jlast]]

Attachment: rel-22.patch

Comment 4

[Jason Laster [:jlast]]

debugger run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=96e77b9b16b51cfe7baa61fcf3c5fffeca5b8899
all runs: https://treeherder.mozilla.org/#/jobs?repo=try&revision=47bf81b6e30b56df4409e05f60b6ac5d3407b57b

Comment 5

[Julian Descottes [:jdescottes]]

Comment on attachment 8959031 [details] [diff] [review]
rel-22.patch

Review of attachment 8959031 [details] [diff] [review]:
-----------------------------------------------------------------

R+ with a skip or fix of the new stepping test + a greener try.

- Meta:
 - assigned, P3, enhancement, blocks meta: OK
 - commit message: OK
 - less than 20 commits: OK
- TRY: KO:
  - leaks for the new test browser_dbg-stepping.js
  - inspector failures from Bug 1431573 (not related to this patch)
  - worried about frequent timeout of browser_addons_debug_webextension.js (hasn't
    happened in the last 4 months)
- Manual test: OK
- README review: OK 
- Properties file review: OK
- New files: OK

::: devtools/client/debugger/new/test/mochitest/browser.ini
@@ +122,5 @@
>  
>  [browser_dbg-asm.js]
>  [browser_dbg-async-stepping.js]
>  [browser_dbg-babel-scopes.js]
> +skip-if = (os == "win" && ccov) # bug 1438797

This was removed, but couldn't be synchronized on master (see https://github.com/devtools-html/debugger.html/pull/5604)

Comment 6

[Julian Descottes [:jdescottes]]

https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=280ea4e51a45669979bb511a58d974851e11d4b2&newProject=try&newRevision=56f080d2cd5764a661a61db1a54195bd59392e7f&framework=1

Comment 7

[Julian Descottes [:jdescottes]]

- complicated.jsdebugger.open: 2% faster
- custom.jsdebugger.close: 7% slower
- custom.jsdebugger.pause: 3% slower
- custom.webconsole.close: 15% faster (???)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/97eff06108ac
Update Debugger Frontend v22. r=jdescottes

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/97eff06108ac