Closed Bug 1445496 Opened 7 years ago Closed 7 years ago

Update Debugger Frontend v22

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → jlaster
Priority: -- → P3
Attached patch rel-22.patchSplinter Review
Attachment #8959031 - Flags: review?(jdescottes)
Severity: normal → enhancement
Status: NEW → ASSIGNED
Comment on attachment 8959031 [details] [diff] [review] rel-22.patch Review of attachment 8959031 [details] [diff] [review]: ----------------------------------------------------------------- R+ with a skip or fix of the new stepping test + a greener try. - Meta: - assigned, P3, enhancement, blocks meta: OK - commit message: OK - less than 20 commits: OK - TRY: KO: - leaks for the new test browser_dbg-stepping.js - inspector failures from Bug 1431573 (not related to this patch) - worried about frequent timeout of browser_addons_debug_webextension.js (hasn't happened in the last 4 months) - Manual test: OK - README review: OK - Properties file review: OK - New files: OK ::: devtools/client/debugger/new/test/mochitest/browser.ini @@ +122,5 @@ > > [browser_dbg-asm.js] > [browser_dbg-async-stepping.js] > [browser_dbg-babel-scopes.js] > +skip-if = (os == "win" && ccov) # bug 1438797 This was removed, but couldn't be synchronized on master (see https://github.com/devtools-html/debugger.html/pull/5604)
Attachment #8959031 - Flags: review?(jdescottes) → review+
- complicated.jsdebugger.open: 2% faster - custom.jsdebugger.close: 7% slower - custom.jsdebugger.pause: 3% slower - custom.webconsole.close: 15% faster (???)
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: