1445546 - Ensure COM is correctly initialized on all threads that call into libcubeb

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, enhancement, P2)

Description

[Matthew Gregan [:kinetik]]

We want to remove the hidden COM initialization inside cubeb to avoid lifetime issues with the thread-local COM data across cubeb API calls.

This is related to https://github.com/kinetiknz/cubeb/pull/424 and https://github.com/kinetiknz/cubeb/issues/416.

This requires minor changes on the Gecko side.  So far, the MediaManager thread is the only cubeb caller that doesn't initialize COM.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=159585597791be3360a6ce91654c933ccdd4bba8&selectedJob=167848968

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: Bug 1445546 - Initialize COM on the MediaManager thread.

Review commit: https://reviewboard.mozilla.org/r/229128/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229128/

Comment 2

[Paul Adenot (:padenot)]

Comment on attachment 8960364 [details]
Bug 1445546 - Initialize COM on the MediaManager thread.

https://reviewboard.mozilla.org/r/229128/#review235072

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4959ee444d48
Initialize COM on the MediaManager thread.  r=padenot

Comment 4

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/4959ee444d48