Closed
Bug 1445546
Opened 3 years ago
Closed 3 years ago
Ensure COM is correctly initialized on all threads that call into libcubeb
Categories
(Core :: Audio/Video: cubeb, enhancement, P2)
Core
Audio/Video: cubeb
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: kinetik, Assigned: kinetik)
References
Details
Attachments
(1 file)
We want to remove the hidden COM initialization inside cubeb to avoid lifetime issues with the thread-local COM data across cubeb API calls. This is related to https://github.com/kinetiknz/cubeb/pull/424 and https://github.com/kinetiknz/cubeb/issues/416. This requires minor changes on the Gecko side. So far, the MediaManager thread is the only cubeb caller that doesn't initialize COM. https://treeherder.mozilla.org/#/jobs?repo=try&revision=159585597791be3360a6ce91654c933ccdd4bba8&selectedJob=167848968
Updated•3 years ago
|
Rank: 19
Priority: -- → P2
Comment hidden (mozreview-request) |
Comment 2•3 years ago
|
||
mozreview-review |
Comment on attachment 8960364 [details] Bug 1445546 - Initialize COM on the MediaManager thread. https://reviewboard.mozilla.org/r/229128/#review235072
Attachment #8960364 -
Flags: review?(padenot) → review+
Pushed by mgregan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4959ee444d48 Initialize COM on the MediaManager thread. r=padenot
Comment 4•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4959ee444d48
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•