Closed Bug 1445553 Opened 6 years ago Closed 6 years ago

More sixgill improvements

Categories

(Core :: JavaScript: GC, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: sfink, Assigned: sfink)

References

(Blocks 1 open bug)

Details

Attachments

(7 files)

Forked off of bug 1443233.
I swear this didn't use to work, but it does now. Make sure we are running sixgill against the same version of gcc it was compiled for.
Attachment #8958699 - Flags: review?(bhackett1024)
Assignee: nobody → sphink
Status: NEW → ASSIGNED
Handle <lambda(foo)>
Attachment #8958700 - Flags: review?(bhackett1024)
I think I had a confusing collision of anonymous structs from different files?
Attachment #8958701 - Flags: review?(bhackett1024)
Ok, this is a hack to avoid infinite recursion. There are probably better, more principled ways to fix this, but it doesn't seem worth much trouble.
Attachment #8958702 - Flags: review?(bhackett1024)
I doubt I ever dug enough to figure out what was really going on here, but I was getting a crash.
Attachment #8958703 - Flags: review?(bhackett1024)
Fix which header we include to check for VOID_CST. With newer gcc, it was getting this wrong.
Attachment #8958704 - Flags: review?(bhackett1024)
Bleh. There are a few more -M flag variants in use now.
Attachment #8958705 - Flags: review?(bhackett1024)
Attachment #8958699 - Flags: review?(bhackett1024) → review+
Attachment #8958700 - Flags: review?(bhackett1024) → review+
Attachment #8958701 - Flags: review?(bhackett1024) → review+
Attachment #8958702 - Flags: review?(bhackett1024) → review+
Attachment #8958703 - Flags: review?(bhackett1024) → review+
Attachment #8958704 - Flags: review?(bhackett1024) → review+
Attachment #8958705 - Flags: review?(bhackett1024) → review+
Ok, that was straightforward. I guess I won't do any fixups after all. Thanks!
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: