1445593 - Factorize common functions defined in *script to scriptworker

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, enhancement)

Description

[Johan Lorenzo [:jlorenzo]]

This will reduce the boilerplate, when we create a new type of scriptwoker instance.

Comment 1

[Johan Lorenzo [:jlorenzo]]

Attachment: [scriptworker] PR: First pass of factorization

Was r+'d by Aki at https://github.com/mozilla-releng/scriptworker/pull/195/#pullrequestreview-102165437.
Landed on master at https://github.com/mozilla-releng/scriptworker/commit/ac64a016319f2b809123066e0fa5e4fd53ec93bc
Released as 10.1.0 at https://pypi.python.org/pypi/scriptworker/10.1.0

Comment 2

[Johan Lorenzo [:jlorenzo]]

Attachment: [scriptworker] PR: Second pass of factorization

Was r+'d by Aki at https://github.com/mozilla-releng/scriptworker/pull/196#pullrequestreview-103530435.
Landed on master at https://github.com/mozilla-releng/scriptworker/commit/e1005729aa0b5214a3d185d045b029816c00184a
Released as 10.2.0 at https://pypi.python.org/pypi/scriptworker/10.2.0

Comment 3

[Johan Lorenzo [:jlorenzo]]

Attachment: [signingscript] PR: Use functions exposed by scriptwoker.client

Was r+'d by Aki at: https://github.com/mozilla-releng/signingscript/pull/47#pullrequestreview-103554864
Landed on master at: https://github.com/mozilla-releng/signingscript/commit/65cbb99ea53896fda9f4844e050a9695c762d24f
Released as signingscript 6.0.0: https://pypi.python.org/pypi/signingscript/6.0.0

Comment 4

[Johan Lorenzo [:jlorenzo]]

Attachment: [build/puppet] Bump signingscript to 6.0.0 a=versionbump

Landed on default: https://hg.mozilla.org/build/puppet/rev/a9ee8794ffc568840da029af437ba5a79320e181
Landed on production: https://hg.mozilla.org/build/puppet/rev/f38983e7cfc62a8f3a6af29decd34ecb6e8ef93e

Comment 5

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: [bouncerscript] PR: Use functions exposed by scriptwoker.client

@JohanLorenzo Sorry to have stolen this but I wanted to give this a try since I had already `bouncerscript` context and I was working on adding more tests for the configurations. This sort-of was incoming anyway and would've blocked my work there. 

A word on `load_json`, I moved it from main scripts under tests since it's being used there, but I'll redo the tests to use integration tests instead of local files. You've set some good example in `shiptitscript` repo which I think is way better than what I currently have now. I filed https://github.com/mozilla-releng/bouncerscript/issues/14 to track this later on.

Comment 6

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: [build/puppet] Bump bouncerscript to 1.1.0 a=versionbump

Before I forget, adding the corresponding puppet patch.

NB: Won't deploy this until it's properly tested on maple.

Comment 7

[Johan Lorenzo [:jlorenzo]]

Attachment: [build/puppet] Bump beetmoverscript, pushapkscript, shipitscript a=versionbump

https://hg.mozilla.org/build/puppet/rev/0c7224c9de2be953f11f67ee9b5be017dd9d7da7

Comment 8

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8960032 [details] [diff] [review]
[build/puppet] Bump bouncerscript to 1.1.0 a=versionbump

https://hg.mozilla.org/build/puppet/rev/e81b49c08344fc5c099dce84db0a7ba03cdcb0d7

Comment 9

[Johan Lorenzo [:jlorenzo]]

Attachment: [shipitscript] PR: Use functions exposed by scriptwoker.client

Was r+'d by Mihai at https://github.com/mozilla-releng/shipitscript/pull/4#pullrequestreview-104522742
Landed on master at https://github.com/mozilla-releng/shipitscript/commit/b1a1b64d06fef59a5231bc316caabb105b837198
Released as part of shipitscript 1.0.0

Comment 10

[Johan Lorenzo [:jlorenzo]]

Comment 7 and 8 landed on production at https://hg.mozilla.org/build/puppet/rev/17464d4fa795d8f522a4016f21373c4b250915b1

Comment 11

[Johan Lorenzo [:jlorenzo]]

Attachment: [pushapkscript] PR: Use functions exposed by scriptwoker.client

Was r+'d by mtabara at https://github.com/mozilla-releng/pushapkscript/pull/35#pullrequestreview-104529550
Landed on master at https://github.com/mozilla-releng/pushapkscript/commit/d1dff7582b0587f53535fe4c90a37d6604d1a3f7
Released as part of pushapkscript 0.5.0

Comment 12

[Johan Lorenzo [:jlorenzo]]

Attachment: [beetmoverscript] PR: Use fonctions exposed by scriptworker.client

Was r+'d by mtabara at https://github.com/mozilla-releng/beetmoverscript/pull/108#pullrequestreview-104606586
Landed on master at https://github.com/mozilla-releng/beetmoverscript/commit/5795bbb890b89c3579a9ef61766c583aa8caf5b9
Was released as part of beetmover 5.0.0.

Comment 13

[Johan Lorenzo [:jlorenzo]]

Attachment: [treescript] PR: Use functions exposed by scriptwoker.client

Was r+'d by Callek at https://github.com/mozilla-releng/treescript/pull/17#pullrequestreview-103917935
Landed on master at https://github.com/mozilla-releng/treescript/commit/8344bcc6861264261da8bf1161c93315a6193481

I didn't release and deploy a new treescript version, because I saw some other changes were ongoing on the master branch. Callek, do you want me to deploy it? Or would you prefer to deal with it later?

Comment 14

[Johan Lorenzo [:jlorenzo]]

All *script were changed but:
* addonscript: that's a brand new project which already benefits from the changes
* balrogscript: that's a python2.7 project, which doesn't import scriptworker package (yet). Ben, is there a "upgrade to py3" bug that I can point to?

Comment 15

[Justin Wood (:Callek)]

(In reply to Johan Lorenzo [:jlorenzo] from comment #13)
> Created attachment 8960203 [details] [review]
> [treescript] PR: Use functions exposed by scriptwoker.client
> 
> I didn't release and deploy a new treescript version, because I saw some
> other changes were ongoing on the master branch. Callek, do you want me to
> deploy it? Or would you prefer to deal with it later?

Feel free to deploy [with a bumped version]. Thanks!

Comment 16

[Johan Lorenzo [:jlorenzo]]

Attachment: [build/puppet] Bump treescript to 0.4 a=versionbump

Landed on default: https://hg.mozilla.org/build/puppet/rev/7e8de7375389e1624639d30974660c04e524cd06
Landed on production: https://hg.mozilla.org/build/puppet/rev/cf3a9b020d5a7a33cd2b10755cda4efb920fbd37

Comment 17

[Johan Lorenzo [:jlorenzo]]

Every script that could be modified was. Let's now close this bug. Please reopen if you experience any issue.

Comment 18

[[e-mail] (:bhearsum)]

(In reply to Johan Lorenzo [:jlorenzo] from comment #14)
> All *script were changed but:
> * addonscript: that's a brand new project which already benefits from the
> changes
> * balrogscript: that's a python2.7 project, which doesn't import
> scriptworker package (yet). Ben, is there a "upgrade to py3" bug that I can
> point to?

I'm not really the owner of balrogscript, but I'm guessing it's py2 because it depends on cli.py, which is py2? If so, no bug that I'm aware of. My guess is that we'll end up rewriting cli.py and maybe balrogclient entirely at some point.

Comment 19

[Aki Sasaki (not active)]

There's https://github.com/mozilla-releng/balrogscript/issues/7 .

Comment 20

[Johan Lorenzo [:jlorenzo]]

Thanks! I left details and pointers in balrogscript#7