1445606 - Package & install commands could produce faulty package without explicit failure

Status: NEW

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

STR:

1. hg update -r f1965cf7425f # base central version
2. make && mach package && mach install # install the base central build on the phone.
3. hg pull -r 9ec62e7ecbc3e7a0960207fc2275dea6d921b076 https://reviewboard-hg.mozilla.org/gecko (my patch from bug 1444489, which add/remove files)
4. make && mach package && mach install # install the patched Fennec
5. goto http://camendesign.com/code/video_for_everybody/test.html and inspect the video controls

Expected:

1. You should see a working video control

Actual:

1. The video control is broken because videocontrols.css style was not applied. Strangely if you type |chrome://global/skin/media/videocontrols.css| in the address bar you can see the file is there in the apk.

My mozconfig:

mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/../obj-@CONFIG_GUESS@

# Build Firefox for Android:
ac_add_options --enable-application=mobile/android
ac_add_options --target=arm-linux-androideabi

# With the following java and javac:
#ac_add_options --with-java-bin-path="/Library/Java/Home/bin"

# With the following Android SDK:
ac_add_options --with-android-sdk="$HOME/.mozbuild/android-sdk-macosx"
ac_add_options --with-android-ndk="$HOME/.mozbuild/android-ndk-r15c"

mk_add_options AUTOCLOBBER=1

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #0)
> Strangely if you type
> |chrome://global/skin/media/videocontrols.css| in the address bar you can
> see the file is there in the apk.
> 

Actually, now the that I look at it again I realize the file was the geckoview one, which I've deleted from my patch...

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Turned out I can workaround this by 

rm -R ../obj-arm-linux-androideabi/faster/ ../obj-arm-linux-androideabi/dist/bin/chrome/geckoview* ../obj-arm-linux-androideabi/dist/geckoview/omni.ja ../obj-arm-linux-androideabi/dist/fennec/omni.ja

(I don't know which file I deleted make this work)

Comment 3

[Nick Alexander :nalexander [he/him]]

Thanks for giving so much debug info, :timdream.  I'm not sure what's going on here:

- is there a startupcache/purgecaches issue?
- is there a geckoview/fennec omnijar conflict?
- is there a packaging issue, where removed files aren't purged?

I think the last one is most likely, but who knows.  I don't have much time to dig into this right now, sorry -- but at least you have a work-around.