1445614 - SetAlternateDesktop failure should not crash the browser.

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P1)

Description

[Bob Owen (:bobowen) (PTO until 27th Jun)]

Currently failure to create an alternate desktop will crash the browser.
It looks like there are cases where this can legitimately fail and certainly chrome only warns.

Comment 1

[Bob Owen (:bobowen) (PTO until 27th Jun)]

Attachment: Only warn when SetAlternateDesktop fails

Comment 2

[Bob Owen (:bobowen) (PTO until 27th Jun)]

Try push (this time actually calling GetLastError instead of logging its pointer):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=816edb8ff6b2ebd7c4d3b5c824564746bc43fe28

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/159e1105bdc7
Only warn when SetAlternateDesktop fails. r=jimm

Comment 4

[Bob Owen (:bobowen) (PTO until 27th Jun)]

Comment on attachment 8958806 [details] [diff] [review]
Only warn when SetAlternateDesktop fails

Sheriff note: the patch that landed was slightly different to the one attached to the bug.

Approval Request Comment
[Feature/Bug causing the regression]:
Alternate Desktop for content process bug 1441824.

[User impact if declined]:
Some users will continue to experience crashes like this:
https://crash-stats.mozilla.com/search/?moz_crash_reason=~alternate desktop&product=Firefox

[Is this code covered by automated tests?]:
Many tests go through the child process launch code.

[Has the fix been verified in Nightly?]:
I don't have STR.

[Needs manual test from QE? If yes, steps to reproduce]: 
No STR, but should be obvious from crash stats.

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
Trivial change to warn and log instead of crash the browser or not start the child.

[String changes made/needed]:
None

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/159e1105bdc7

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 8958806 [details] [diff] [review]
Only warn when SetAlternateDesktop fails

windows crash fix for beta60

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f08e27292f7e