Closed Bug 1445620 Opened 7 years ago Closed 7 years ago

Android bustage in gfx/skia/skia/src/core/SkICC.cpp when Gecko 61 merges to Beta on 2018-04-26

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox59 --- unaffected
firefox60 + fixed
firefox61 + verified

People

(Reporter: aryx, Assigned: lsalzman)

References

Details

(Whiteboard: [gfx-noted])

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=742ee48b8f7605fe337ebeca93bd853fa8285c4b&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Log: https://treeherder.mozilla.org/logviewer.html#?job_id=167912407&repo=try Issue from bug 1444506? [task 2018-03-14T12:33:31.908Z] 12:33:31 INFO - /builds/worker/workspace/build/src/gfx/skia/skia/src/core/SkICC.cpp:412: error: undefined reference to 'SkMD5::SkMD5()' [task 2018-03-14T12:33:31.909Z] 12:33:31 INFO - /builds/worker/workspace/build/src/gfx/skia/skia/src/core/SkICC.cpp:416: error: undefined reference to 'SkMD5::write(void const*, unsigned int)' [task 2018-03-14T12:33:31.909Z] 12:33:31 INFO - /builds/worker/workspace/build/src/gfx/skia/skia/src/core/SkICC.cpp:420: error: undefined reference to 'SkMD5::write(void const*, unsigned int)' [task 2018-03-14T12:33:31.909Z] 12:33:31 INFO - /builds/worker/workspace/build/src/gfx/skia/skia/src/core/SkICC.cpp:422: error: undefined reference to 'SkMD5::finish(SkMD5::Digest&)' [task 2018-03-14T12:33:31.909Z] 12:33:31 INFO - clang++: error: linker command failed with exit code 1 (use -v to see invocation) [task 2018-03-14T12:33:31.909Z] 12:33:31 INFO - /builds/worker/workspace/build/src/config/rules.mk:699: recipe for target 'libxul.so' failed [task 2018-03-14T12:33:31.910Z] 12:33:31 INFO - make[4]: *** [libxul.so] Error 1
Flags: needinfo?(lsalzman)
This is going to block the uplift to 60 as well.
status-firefox60: unaffected → affected
tracking-firefox60: --- → +
tracking-firefox61: ? → +
Pushed a follow-up that should fix this by adding in the missing SkMD5.cpp
Flags: needinfo?(lsalzman)
Whiteboard: [gfx-noted]
Assignee: nobody → lsalzman
Target Milestone: --- → mozilla61
The fix for this was included in the uplift to Beta.
status-firefox60: affected → fixed
You need to log in before you can comment on or make changes to this bug.