Closed Bug 1445652 Opened 6 years ago Closed 6 years ago

Re-enable some places tests for code coverage

Categories

(Firefox :: Bookmarks & History, enhancement, P2)

Product:
Firefox
Component:
Bookmarks & History
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Bug 1445652 - Re-enable some places tests for code coverage.
59 bytes, text/x-review-board-request
RyanVM
: review+
Details 
Bug 1423667 comment 2 / comment 3 disabled a lot of places tests for code coverage.

Whilst some are still broken, there's quite a few that can be re-enabled. I'd like to get these cleaned up so we can be clearer as to what is/isn't broken.
Comment on attachment 8958836 [details]
Bug 1445652 - Re-enable some places tests for code coverage.

https://reviewboard.mozilla.org/r/227722/#review233458

Stealing review from RyanVM. This is great, it must be due to the update of Clang revision.
Attachment #8958836 - Flags: review+
Comment on attachment 8958836 [details]
Bug 1445652 - Re-enable some places tests for code coverage.

https://reviewboard.mozilla.org/r/227722/#review233460

Assuming you've verified this on Try, WFM!
Attachment #8958836 - Flags: review?(ryanvm) → review+
(In reply to Marco Castelluccio [:marco] from comment #2)
> Stealing review from RyanVM. This is great, it must be due to the update of
> Clang revision.

I suspect these were just disabled too aggressively, see bug 1423667 comment 4 (oops, I meant to reference 3/4 in comment 0 of this bug!).

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)
> Assuming you've verified this on Try, WFM!

I've been verifying on locally-pushed try builds, but now have a final one via mozreview just to make sure!
(In reply to Mark Banner (:standard8) from comment #4)
> (In reply to Marco Castelluccio [:marco] from comment #2)
> > Stealing review from RyanVM. This is great, it must be due to the update of
> > Clang revision.
> 
> I suspect these were just disabled too aggressively, see bug 1423667 comment
> 4 (oops, I meant to reference 3/4 in comment 0 of this bug!).

IIRC, I tried at the time and many of them (but not all) were actually failing. I forgot then to re-enable those which weren't failing.
I've just added an additional skip for browser_library_infoBox.js as that's fairly frequently failing as well for some reason.
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 571c6cbd3f68225895e076f56a7b5a97eda13d1e -d 68737a515062: rebasing 452279:571c6cbd3f68 "Bug 1445652 - Re-enable some places tests for code coverage. r=marco,RyanVM" (tip)
merging browser/components/places/tests/browser/browser.ini
warning: conflicts while merging browser/components/places/tests/browser/browser.ini! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5df8d26b1201
Re-enable some places tests for code coverage. r=marco,RyanVM
https://hg.mozilla.org/mozilla-central/rev/5df8d26b1201
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: