1445664 - firefox.js comments are outdated

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, enhancement, P3)

Description

[Gian-Carlo Pascutto [:gcp]]

The comments about sandboxing in firefox.js are rather outdated, we should update that.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Attachment: Bug 1445664 - Update firefox.js comments about Linux sandboxing.

Review commit: https://reviewboard.mozilla.org/r/228064/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228064/

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 8959185 [details]
Bug 1445664 - Update firefox.js comments about Linux sandboxing.

https://reviewboard.mozilla.org/r/228064/#review233998

Thanks for fixing this.

::: browser/app/profile/firefox.js:1097
(Diff revision 1)
>  // its Windows/Mac counterpart, but on Linux it's an integer which means:
>  // 0 -> "no sandbox"
>  // 1 -> "content sandbox using seccomp-bpf when available"
>  // 2 -> "seccomp-bpf + write file broker"
>  // 3 -> "seccomp-bpf + read/write file brokering"
> -// 4 -> all of the above + network/socket restrictions
> +// 4 -> all of the above + network/socket/ipc restrictions + chroot

SysV IPC is restricted at level 1 (if we don't detect something that needs it), not 4.  It's one of the few things PulseAudio *doesn't* use (but ALSA does).

Comment 3

[Gian-Carlo Pascutto [:gcp]]

>SysV IPC is restricted at level 1 (if we don't detect something that needs it), not 4

I was thinking of IPC namespaces when I wrote this. SysV IPC calls fall under "seccomp-bpf".

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

(In reply to Gian-Carlo Pascutto [:gcp] from comment #3)
> >SysV IPC is restricted at level 1 (if we don't detect something that needs it), not 4
> 
> I was thinking of IPC namespaces when I wrote this. SysV IPC calls fall
> under "seccomp-bpf".

CLONE_NEWIPC is also set at level 1.

Comment 5

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8959185 [details]
Bug 1445664 - Update firefox.js comments about Linux sandboxing.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/228064/diff/1-2/

Comment 6

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8959185 [details]
Bug 1445664 - Update firefox.js comments about Linux sandboxing.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/228064/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1226c13b7722
Update firefox.js comments about Linux sandboxing. r=jld

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/1226c13b7722