1445758 - (CVE-2025-9186) Focus Custom Tabs do not show the top level domain +1 in the address bar

Status: RESOLVED FIXED

(Focus :: General, enhancement, P3)

Description

[Kevin Brosnan [Ex-Mozilla]]

When displaying long URLs in the address bar after the page is loaded the top level domain +1 should be shown. This should work when the user enters one of these domains into the address bar and when Focus is used as a custom tab. 

See bug 1432624 and bug 1236431 for some prior art in Firefox for Android

https://long-extended-subdomain-name-containing-many-letters-and-dashes.badssl.com/

https://longextendedsubdomainnamewithoutdashesinordertotestwordwrapping.badssl.com/

Comment 1

[Daniel Veditz [:dveditz]]

We might as well unhide this and attempt to forestall dupes

Comment 2

[Chris Peterson [:cpeterson]]

sec-low -> P3

Comment 3

[Chris Peterson [:cpeterson]]

Changing Severity normal to S3.

Comment 4

[Chris Peterson [:cpeterson]]

Enhancements should have severity N/A.

Comment 5

[Michel Le Bihan]

The fix for this bug is actually trivial. We only need to set ToolbarFeature.RenderStyle.RegistrableDomain for Custom Tabs instead of ToolbarFeature.RenderStyle.ColoredUrl like in https://hg-edge.mozilla.org/mozilla-central/rev/64d8dfa544cb when custom tabs are used.

I'm just not sure whether I should pass isCustomTabSession or renderStyle to BrowserToolbarIntegration or if this could be just inferred from customTabId being null.

Comment 6

[Mihai Adrian Carare [:mcarare]]

For the moment you can infer it from the customTabId value since that is the pattern used in that class.

Comment 7

[Michel Le Bihan]

Attachment: Bug 1445758 - Show the registrable domain in Focus Custom Tabs toolbar. r=mcarare

Comment 8

[Michel Le Bihan]

Could you please review the attached revision?

Comment 9

[Michel Le Bihan]

Could you please look again at the attached revision?

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9777b4b03bbd
https://hg.mozilla.org/integration/autoland/rev/68f83bff6a2c
Show the registrable domain in Focus Custom Tabs toolbar. r=mcarare,android-reviewers

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/94989ad268aa
https://hg.mozilla.org/integration/autoland/rev/26c9c225e74d
Revert "Bug 1445758 - Show the registrable domain in Focus Custom Tabs toolbar. r=mcarare,android-reviewers" for causing perma fenix debug failures @ BrowserToolbarIntegrationTest

Comment 12

[Sandor Molnar[:smolnar]]

Backed out for causing perma fenix debug failures @ BrowserToolbarIntegrationTest

Backout link: https://hg.mozilla.org/integration/autoland/rev/26c9c225e74d7872acc517fb4359972aa6cb1f9c

Push with failures

Failure log -> file:///builds/worker/checkouts/gecko/mobile/android/focus-android/app/src/test/java/org/mozilla/focus/browser/integration/BrowserToolbarIntegrationTest.kt:87:17: error: No value passed for parameter 'renderStyle'.

Comment 13

[Michel Le Bihan]

Sorry for that. I added a default renderStyle and run the tests locally.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/466ba1301b9d
https://hg.mozilla.org/integration/autoland/rev/b2d4d01e0a97
Show the registrable domain in Focus Custom Tabs toolbar. r=mcarare,android-reviewers

Comment 15

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b2d4d01e0a97