Closed
Bug 1445768
Opened 7 years ago
Closed 7 years ago
Web Replay: Avoid recording atomic accesses in logging code
Categories
(Core :: General, enhancement)
Core
General
Tracking
()
RESOLVED
INVALID
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | affected |
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(2 files)
|
698 bytes,
patch
|
Details | Diff | Splinter Review | |
|
435 bytes,
patch
|
Details | Diff | Splinter Review |
Some destructors are logged, which can affect the recording due to accesses on recorded atomics in the logging code. This isn't great because we don't in general require objects to be destroyed at the exact same place while recording and replaying (most atomic refcounts are not recorded) and can get record/replay mismatches as a result, and because this bloats the recording unnecessarily.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → bhackett1024
|
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
Avoid recording uses of a mutex related to the atomics addressed by the patch above.
https://hg.mozilla.org/projects/ash/rev/178829d2bd8a7b676d9ced6b2de6e8e0bdf76b5e
|
|
Assignee | |
Comment 3•7 years ago
|
||
Closing this bug, all the changes here will be reviewed in separate bugs dependent on bug 1422587.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•