1445793 - Verify new email address before saving it

Status: RESOLVED MOVED

(Webtools Graveyard :: Pontoon, defect, P5)

Description

[Djfe]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180310025718

Steps to reproduce:

I haven't verified it, but the settings tell me:
"Changing your email address will cause a logout. Make sure the new one is correct before saving!"



Expected results:

It would be nice, if Pontoon would send an e-mail to the new address for verifying it's correctness before accepting the change.

Though I'm not sure if the setting is even still valid, which is another question of mine:
Is the input actually needed?
I had to login using accounts.firefox.com, so it should usually be enough to change it there, right?

This issue is of very low priority, I was just wondering about this.

Comment 1

[Matjaz Horvat [:mathjazz]]

Passing to Adrian, as he designed the feature.

Comment 2

[[DEACTIVATED] Adrian Gaudebert]

I thought about that while we were working on the feature. The thing is that Pontoon actually shouldn't handle the email address, as that's delegated to Firefox Accounts. We store it so that we can have an identifier, of course, but I believe we shouldn't really be using that. Also, verification of that email address is the responsibility of FF Accounts. 

What we could do is ask the user to log in with the new email address before we validate the change. I know that some systems do that, but it's super painful because sign-in systems have a tendency to remember your previous log in and log you automatically. 

I'm not opposed to doing that but I think it is very low priority and slightly too complex for the benefits we would get.

Comment 3

[BMO Automation]

*This bug has been moved to GitHub.*

*Please check it out on https://github.com/mozilla/pontoon/issues.*