Closed
Bug 144584
Opened 23 years ago
Closed 23 years ago
Update localeVersion in 1.0.1 branch for newer milestone releases
Categories
(SeaMonkey :: Build Config, defect)
SeaMonkey
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tao, Assigned: tao)
References
Details
(Whiteboard: [adt1 RTM] custrtm+ [ETa 06/29])
Attachments
(2 files, 2 obsolete files)
54.48 KB,
patch
|
tao
:
review+
tao
:
superreview+
|
Details | Diff | Splinter Review |
13.73 KB,
patch
|
tao
:
review+
tao
:
superreview+
|
Details | Diff | Splinter Review |
This is a routine work and might need to be part of the build config build
Hi, Don:
Since ADT (jaimejr) suggested that this might belong to BuildConfig, would you
please consult granrose if we should put this under one of his meta bugs to get
blanket approval?
thx
Updated•23 years ago
|
Updated•23 years ago
|
Whiteboard: [adt1 RTM] → [adt1 RTM] custrtm
Updated•23 years ago
|
Whiteboard: [adt1 RTM] custrtm → [adt1 RTM] custrtm+
Comment 2•23 years ago
|
||
Can we get a status update on this bug?
These localeVersion bugs are not "fixed" until a day or two before the actual
milestone.
HI, leaf / dn: would you please r/sr these patches? They are the routine
localeVersion # flipping tasks :-) You can compare them to patches in 142823.
Status: NEW → ASSIGNED
Comment 8•23 years ago
|
||
Comment on attachment 89493 [details] [diff] [review]
moz patch
r=leaf with the caveat or changing 1.0.1rc to 1.0.1rc1 (if we're going to have
multiple rcs, let's start numbering them properly)
Attachment #89493 -
Flags: review+
Comment 9•23 years ago
|
||
Comment on attachment 89494 [details] [diff] [review]
ns patch
r=leaf with the same caveat as the moz patch.
Attachment #89494 -
Flags: review+
Comment 10•23 years ago
|
||
adt1.0.1+ (on ADT's behalf) approval for checkin into the 1.0 branch, pending
drivers' approval and positive sr=. pls check this in asap, then add the
"fixed1.0.1" keyword.
Whiteboard: [adt1 RTM] custrtm+ → [adt1 RTM] custrtm+ [ETa 06/29]
Comment 11•23 years ago
|
||
Ew, "1.0.1rc"? Do we really expect localizations to change between 1.0.1
pre-release (if any) and the final? I'd have preferred plain "1.0.1". If
localizations do happen to break between the two then oh well, casualty of a
release candidate. (I'd have made a different argument for the 1.0 release
candidates since those were a bigger deal with more change expected.)
but ok, sr=dveditz on both patches whether you change it or not.
Updated•23 years ago
|
Attachment #89494 -
Flags: superreview+
Updated•23 years ago
|
Attachment #89493 -
Flags: superreview+
Assignee | ||
Comment 12•23 years ago
|
||
use 1.0.1rc1 instead
Attachment #89493 -
Attachment is obsolete: true
Attachment #89494 -
Attachment is obsolete: true
Assignee | ||
Comment 13•23 years ago
|
||
moz patch w/ 1.0.1rc1 instead of 1.0.1rc
Assignee | ||
Comment 14•23 years ago
|
||
Comment on attachment 89608 [details] [diff] [review]
moz patch w/ 1.0.1rc1
inherit r=leaf from previous patch
Attachment #89608 -
Flags: review+
Assignee | ||
Comment 15•23 years ago
|
||
Comment on attachment 89608 [details] [diff] [review]
moz patch w/ 1.0.1rc1
inherit r=dveditz from previous patch
Attachment #89608 -
Flags: superreview+
Assignee | ||
Comment 16•23 years ago
|
||
Comment on attachment 89609 [details] [diff] [review]
ns patch w/ 1.0.1rc1
inherit r=leaf,sr=dviditz from previous patch
Attachment #89609 -
Flags: superreview+
Attachment #89609 -
Flags: review+
Comment 17•23 years ago
|
||
please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.
Keywords: mozilla1.0.1 → mozilla1.0.1+
Assignee | ||
Comment 18•23 years ago
|
||
into the branch. Ying - please flip regca's as well, thx!
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Keywords: mozilla1.0.1+ → fixed1.0.1
Resolution: --- → FIXED
Comment 19•22 years ago
|
||
tao - how to verify?
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•