1445860 - NullPtr crash on setting Identity on RecvOnly Transceiver

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Nils Ohlmeier [:drno]]

STR:
- open https://mozilla.github.io/webrtc-landing/
- tick the "one-way only" box
- click "start"

Result:

#01: RefPtr<mozilla::dom::MediaStreamTrack>::operator->() const[/Users/nohlmeier/src/mozilla-central/objdir-x86_64-apple/dist/NightlyDebug.app/Contents/MacOS/XUL +0x1792904]
#02: mozilla::MediaPipelineTransmit::UpdateSinkIdentity_m(mozilla::dom::MediaStreamTrack const*, nsIPrincipal*, mozilla::PeerIdentity const*)[/Users/nohlmeier/src/mozilla-central/objdir-x86_64-apple/dist/NightlyDebug.app/Contents/MacOS/XUL +0x17931ef]
#03: mozilla::TransceiverImpl::UpdateSinkIdentity(mozilla::dom::MediaStreamTrack const*, nsIPrincipal*, mozilla::PeerIdentity const*)[/Users/nohlmeier/src/mozilla-central/objdir-x86_64-apple/dist/NightlyDebug.app/Contents/MacOS/XUL +0x17fa5b2]
#04: mozilla::PeerConnectionMedia::UpdateSinkIdentity_m(mozilla::dom::MediaStreamTrack const*, nsIPrincipal*, mozilla::PeerIdentity const*)[/Users/nohlmeier/src/mozilla-central/objdir-x86_64-apple/dist/NightlyDebug.app/Contents/MacOS/XUL +0x17da2a4]
#05: mozilla::PeerConnectionImpl::SetPeerIdentity(nsTSubstring<char16_t> const&)[/Users/nohlmeier/src/mozilla-central/objdir-x86_64-apple/dist/NightlyDebug.app/Contents/MacOS/XUL +0x17d9ec8]
#06: mozilla::PeerConnectionImpl::SetPeerIdentity(nsTSubstring<char16_t> const&, mozilla::ErrorResult&)[/Users/nohlmeier/src/mozilla-central/objdir-x86_64-apple/dist/NightlyDebug.app/Contents/MacOS/XUL +0x2d358c1]
#07: mozilla::dom::PeerConnectionImplBinding::set_peerIdentity(JSContext*, JS::Handle<JSObject*>, mozilla::PeerConnectionImpl*, JSJitSetterCallArgs)[/Users/nohlmeier/src/mozilla-central/objdir-x86_64-apple/dist/NightlyDebug.app/Contents/MacOS/XUL +0x2d357b4]

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1445860: set PeerIdenity only on transmitting Transceivers.

Review commit: https://reviewboard.mozilla.org/r/227954/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227954/

Comment 2

[Nils Ohlmeier [:drno]]

Comment on attachment 8959061 [details]
Bug 1445860: set PeerIdenity only on transmitting Transceivers.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227954/diff/1-2/

Comment 3

[Martin Thomson [:mt:]]

Comment on attachment 8959061 [details]
Bug 1445860: set PeerIdenity only on transmitting Transceivers.

https://reviewboard.mozilla.org/r/227954/#review233772

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0665d23d7e87
set PeerIdenity only on transmitting Transceivers. r=mt

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/0665d23d7e87