Closed Bug 1445940 Opened 2 years ago Closed 2 years ago

Uplift adb*.py patches from Autophone to mozdevice/adb*.py

Categories

(Testing :: Mozbase, enhancement, P1)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: bc, Assigned: gbrown)

References

Details

(Keywords: meta)

Attachments

(2 files)

Sorry I didn't do this at the time, but there are several patches I landed on Autophone that are not in mozdevice's copy of adb*.py. Let's track them here.
I reviewed patches to Autophone's version compared to mozdevice's version and checked if the changes in Autophone were present in mozdevice. These were the bugs which were not present.

Geoff: Could you look into bring these over? I think they may have an effect on some of the patches you are working on to convert to adb*.py.
Depends on: 1237755, 1245900, 1401617
Flags: needinfo?(gbrown)
bug 1245900 is a wontfix, so I'm not sure that this made it into autophone.
No longer depends on: 1245900
Will do. I should have thought to check on this earlier.
Flags: needinfo?(gbrown)
If I apply the changes from bug 1237755 and bug 1401617 to mozilla-central, it looks to me like the remaining differences are changes landed on mozilla-central, but missing from autophone:

 - bug 1397849
 - bug 1440714

My patches in bug 1440714 appear to continue to work unmodified.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=805929ccdae4e8f970c8e7da03811415b59be16e
Assignee: nobody → gbrown
Priority: -- → P1
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71c629bdedfe
adb_android.py - use activity name org.mozilla.gecko.BrowserApp when launching Fennec, r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a8be97effff
fix adb_android.py detection of bool extras in launch_application, r=bc
See Also: → 1440714
https://hg.mozilla.org/mozilla-central/rev/71c629bdedfe
https://hg.mozilla.org/mozilla-central/rev/7a8be97effff
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.