1445940 - Uplift adb*.py patches from Autophone to mozdevice/adb*.py

Status: RESOLVED FIXED

(Testing :: Mozbase, enhancement, P1)

Description

[Bob Clary [:bc] (inactive)]

Sorry I didn't do this at the time, but there are several patches I landed on Autophone that are not in mozdevice's copy of adb*.py. Let's track them here.

Comment 1

[Bob Clary [:bc] (inactive)]

I reviewed patches to Autophone's version compared to mozdevice's version and checked if the changes in Autophone were present in mozdevice. These were the bugs which were not present.

Geoff: Could you look into bring these over? I think they may have an effect on some of the patches you are working on to convert to adb*.py.

Comment 2

[Bob Clary [:bc] (inactive)]

bug 1245900 is a wontfix, so I'm not sure that this made it into autophone.

Comment 3

[Geoff Brown [:gbrown] (pto Jul 1-19)]

Will do. I should have thought to check on this earlier.

Comment 4

[Geoff Brown [:gbrown] (pto Jul 1-19)]

If I apply the changes from bug 1237755 and bug 1401617 to mozilla-central, it looks to me like the remaining differences are changes landed on mozilla-central, but missing from autophone:

 - bug 1397849
 - bug 1440714

My patches in bug 1440714 appear to continue to work unmodified.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=805929ccdae4e8f970c8e7da03811415b59be16e

Comment 5

[Geoff Brown [:gbrown] (pto Jul 1-19)]

Attachment: originally landed in autophone in bug 1237755, rebased for mozilla-central

Comment 6

[Geoff Brown [:gbrown] (pto Jul 1-19)]

Attachment: originally landed in autophone in bug 1445950, rebased for mozilla-central

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71c629bdedfe
adb_android.py - use activity name org.mozilla.gecko.BrowserApp when launching Fennec, r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a8be97effff
fix adb_android.py detection of bool extras in launch_application, r=bc

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/71c629bdedfe
https://hg.mozilla.org/mozilla-central/rev/7a8be97effff