Closed Bug 1445947 Opened 4 years ago Closed 4 years ago

Do not assert about re-protection of pages with the same flags.

Categories

(Core :: JavaScript: GC, enhancement, P1)

All
Windows
enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: nbp, Assigned: nbp)

References

Details

Attachments

(1 file)

Handling code to avoid re-protection might be more efficient, but sometimes, we do not care as much about the efficiency and more about the correctness, such as in Bug 1437600.
Assignee: nobody → nicolas.b.pierron
Status: NEW → ASSIGNED
Priority: -- → P1
Comment on attachment 8959126 [details] [diff] [review]
Remove re-protection warnings from Windwos VirtualProtect calls.

Review of attachment 8959126 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, I don't think these assertions are particularly useful.
Attachment #8959126 - Flags: review?(emanuel.hoogeveen) → review+
Pushed by npierron@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a33782324009
Remove re-protection warnings from Windows VirtualProtect calls. r=ehoogeveen
https://hg.mozilla.org/mozilla-central/rev/a33782324009
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.