Closed Bug 1445969 Opened 2 years ago Closed 2 years ago

js/src/make-source-package.sh: Remove some old code related to b2g

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
trivial

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: Sylvestre, Assigned: yor, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [good first bug])

Attachments

(1 file)

Assignee: nobody → yor
Blocks: nukeb2g
Comment on attachment 8961122 [details]
Bug 1445969 - removed obsolete code related to b2g

https://reviewboard.mozilla.org/r/229926/#review236920
Attachment #8961122 - Flags: review?(yor)
Attachment #8961122 - Flags: review?(yor)
Attachment #8961122 - Flags: review?(sledru)
Comment on attachment 8961122 [details]
Bug 1445969 - removed obsolete code related to b2g

https://reviewboard.mozilla.org/r/229926/#review237418

In theory, I would not be the reviewer for such patch but, as it is trivial, I am going to r+ it.
Bravo for your first patch in Firefox Yan!
Attachment #8961122 - Flags: review?(sledru) → review+
According to the documentation [1], you should be able to use the autoland option (in the automation menu).

This because I am the reviewer and I have a L3 access.


[1] http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/autoland.html
I can't autoland because I only have L1 access.
hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files
remote: 
remote: 
remote: ************************** ERROR ****************************
remote: Rev 710a1bdecf24 needs "Bug N" or "No bug" in the commit message.
remote: Yan Or <yor@mozilla.com>
remote: 1445969 - removed obsolete code related to b2g r=sylvestre
remote: 
remote: MozReview-Commit-ID: 3zc6qWT2opS
remote: *************************************************************
remote: 
remote: 
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.c_commitmessage hook failed
abort: push failed on remote
Updated the commit message.  Please autoland.
Flags: needinfo?(sledru)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/317c00f07c39
removed obsolete code related to b2g r=sylvestre
https://hg.mozilla.org/mozilla-central/rev/317c00f07c39
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Landed!
Flags: needinfo?(sledru)
You need to log in before you can comment on or make changes to this bug.