1446007 - The "x" button is not highlighted on hover in High Contrast Theme

Status: NEW

(Firefox :: Normandy Client, defect, P5)

Description

[roxleitan]

[Affected versions]: 
Firefox Beta 60.0b3

[Affected platforms]:
Windows 7 x64

[Prerequisites]:
You need access to New Admin interface (https://normandy-admin.stage.mozaws.net/control-new)
1. Set the app.normandy.dev_mode preference to true to run recipes immediately on startup.
2. Set the app.normandy.logging.level preference to 0 to enable more logging.
3. Set the security.content.signature.root_hash preference to DB:74:CE:58:E4:F9:D0:9E:E0:42:36:BE:6C:C5:C4:F6:6A:E7:74:7D:C0:21:42:7A:03:BC:2F:57:0C:8B:9B:90.
4. Set the preference value for app.normandy.api_url set to https://normandy.stage.mozaws.net/api/v1

[Steps to reproduce]:
1. Open Admin Interface.
2. In the Control Interface, click on New Recipe.
3. In the Name field, set a recipe name.
4. In the Filter Expression set a filter expression (e.g. 1==1).
5. From the action DropDown, select type "show-heartbeat"
6. Type a survey Id in the survey ID textbox.
7. In the Message field, type in a custom message.
8. In the Engagement button label, introduce a label if your heartbeat has a button or leave empty for no button to be displayed.
9. Set "about:plugins" as a Post Answer URL.
10. Input a message into the Learn More Message field.
11. Input "about:support" into the learn More URL.
12. From the dropDown selector, select Show this prompt to users once.
13. Click On "Save" button
14. Go to:Personalize> Themes> Theme Settings and activate a High Contrast Theme
15. Open FF having the pre-requisites set and open the browser console
16. Hover with mouse over "x" button from the heartbeat survey

[Expected result]:
The "x" button should be highlighted on hover (like in normal theme)

[Actual result]:
The "x" button is not highlighted

Comment 1

[Michael Cooper [:mythmon]]

> Go to:Personalize> Themes> Theme Settings and activate a High Contrast Theme

Can you be more specific here? I don't have any themes labeled "High Contrast". I have "Default", "Light", "Dark", "A Web Browser Renaissance", "Space Fantasy" and "Pastel Gradient".

Comment 2

[roxleitan]

This refers to system theme (Windows).
I cannot reproduce on Ubuntu using the High Contrast theme from Ubuntu Universal Accessibility.

Comment 3

[Michael Cooper [:mythmon]]

This doesn't seem like a high priority problem to me. We're planning to replace heartbeat with something better in the medium-term, and this doesn't prevent users from dismissing the dialog. I think that a close button is common enough that the hover effect is nice, not mandatory. Given all that, I'm going to set this as a P5 (not planning to work on this, but will accept patches).