1446117 - Fix regressed read/write timeout of sockets

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: v1

I forgot to reengage the timeout after we called on the handler (OnSocketReady).  Somehow I through we were adding sockets to the active list on every poll iteration...  adds also few logs to catch any more problems with it

and I also thought we had a test for this...  probably should build one, but I'm kinda lazy for it :)

Comment 2

[Honza Bambas (:mayhemer)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=029e4985c055b62bca6c03c76c0cf080a1d0c8c3

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8959298 [details] [diff] [review]
v1

Unsolicited feedback: That fixes bug 1445174 (but I'm sure you've tried it yourself).

Comment 4

[Honza Bambas (:mayhemer)]

Comment on attachment 8959298 [details] [diff] [review]
v1

Thanks, but the patch is still wrong.  Another update needed.

Comment 5

[Honza Bambas (:mayhemer)]

Attachment: v2

I've changed the api slightly, now we have EnsureTimeout(now) that makes sure we mark the epoch for timeout calculation when not already marked, so this can be called repeatedly on any place we want to start the socket timeout, which is when we are about to poll it - this was the missing piece.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b528c1e432af59f7031e6cf2d48644057225456

Comment 6

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Comment on attachment 8959566 [details] [diff] [review]
v2

Review of attachment 8959566 [details] [diff] [review]:
-----------------------------------------------------------------

nit: Write a more detailed description regarding what the bug was and how we fixed it.

::: netwerk/base/nsSocketTransportService2.h
@@ +172,5 @@
>  
>      public:
>          bool IsTimedOut(PRIntervalTime now) const;
> +        void EnsureTimeout(PRIntervalTime now);
> +        void DisengageTimeout();

Add comments describing what these do.

Comment 7

[Honza Bambas (:mayhemer)]

Attachment: v2.1

updated.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1970adec8557
Make sure we also mark timeout epoch on a network socket when we are polling it for read/write, fix regression from bug 1444160. r=valentin

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1970adec8557