Closed
Bug 1446142
Opened 8 years ago
Closed 8 years ago
ensure we're set up to include Activity Stream "secret DSN" in public AS source code
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
People
(Reporter: dmosedale, Assigned: dmosedale)
References
(Blocks 1 open bug)
Details
Crash Data
Like Screenshots, Activity Stream doesn't have "real" origins, which means that we also need to use the "Secret" DSN to make Sentry work for us:
https://bugzilla.mozilla.org/show_bug.cgi?id=1369162#c1
| Assignee | ||
Comment 1•8 years ago
|
||
We'd like to do the same thing, and so I'm needinfo-ing :g-k from Cloud Security Ops to verify that that's a reasonable thing to do, and wezhou, to ensure that we've got any necessary rate-limiting filters in place on the server side.
This should be sufficient for landing this code in Nightly set to not ride the trains.
I've filed bug 1446146 to implement client-side sub-sampling for before we ride the trains.
Flags: needinfo?(wezhou)
Flags: needinfo?(gguthe)
Works for me.
As :dmose points out above, the new tab page doesn't have an origin so we treat it like a native app or binary. For those use cases, Sentry recommends distributing the full "Secret" DSN key which can only submit reports and wezhou can revoke if necessary.
Flags: needinfo?(gguthe)
Thanks for the heads-up Dan!
I think our current limit should be enough for the nightly use. But please give me another heads-up when it's going to ride the train, so I can watch and make adjustment accordingly.
Thanks!
Flags: needinfo?(wezhou)
Updated•8 years ago
|
Iteration: --- → 61.1 - Mar 26
status-firefox60:
--- → wontfix
status-firefox61:
--- → affected
Priority: -- → P1
| Assignee | ||
Comment 4•8 years ago
|
||
This bug has the signoffs we need to land in nightly. I've made a note in the user-story of the bug for implementing client-side sub-sampling to ping wezhou again in prep for riding the trains.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Target Milestone: --- → Firefox 61
Updated•6 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•