1446166 - Ensure that WebRenderUserData's are removed when the LayerManager is destroyed.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Jeff Muizelaar [:jrmuizel]]

This let's us avoid having to check whether we have the right one when getting them.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1446166. Ensure that WebRenderUserData's are removed when LayerManager is destroyed.

This let's us avoid having to check whether we have the right one when getting them.

Review commit: https://reviewboard.mozilla.org/r/228188/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228188/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8959348 [details]
Bug 1446166. Ensure that WebRenderUserData's are removed when LayerManager is destroyed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/228188/diff/1-2/

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8959348 [details]
Bug 1446166. Ensure that WebRenderUserData's are removed when LayerManager is destroyed.

https://reviewboard.mozilla.org/r/228188/#review234016

::: commit-message-32f22:3
(Diff revision 2)
> +Bug 1446166. Ensure that WebRenderUserData's are removed when LayerManager is destroyed. r=kats
> +
> +This let's avoid having to check whether we have the right one when getting them.

s/let's/lets/

::: gfx/layers/wr/WebRenderCommandBuilder.cpp:34
(Diff revision 2)
>    RemoveUnusedAndResetWebRenderUserData();
> +  MOZ_RELEASE_ASSERT(mWebRenderUserDatas.Count() == 0);

I don't know if this is sufficient. There might be some WebRenderUserData instances that got used on the last display list build and so are marked "used" at the point of this call to RemoveUnusedAndResetWebRenderUserData().

I think it would be better to make this function take a bool argument that makes it ignore the used flag and just unconditionally delete all the things, and set that argument here (but not at the other call site).

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8959348 [details]
Bug 1446166. Ensure that WebRenderUserData's are removed when LayerManager is destroyed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/228188/diff/2-3/

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8959348 [details]
Bug 1446166. Ensure that WebRenderUserData's are removed when LayerManager is destroyed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/228188/diff/3-4/

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8959348 [details]
Bug 1446166. Ensure that WebRenderUserData's are removed when LayerManager is destroyed.

https://reviewboard.mozilla.org/r/228188/#review234026

Thanks, that makes sense!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7171c0f021f
Ensure that WebRenderUserData's are removed when LayerManager is destroyed. r=kats

Comment 8

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/e7171c0f021f