1446285 - Recent WPTs related to worker shutdown (bug 1436784) use toSource() instead of toString()

Status: RESOLVED FIXED

(Core :: DOM: Workers, enhancement)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: toSource.patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8959455 [details] [diff] [review]
toSource.patch

I assume you tested this works on chrome too :)
https://developer.mozilla.org/en-US/docs/Mozilla/QA/web-platform-tests#Running_tests_in_other_browsers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb42e9c14d4e
WPT should use toString() and not toSource(), r=smaug

Comment 4

[Andrea Marchesini [:baku]]

tests fixed.

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10070 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/fb42e9c14d4e

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 9

[Ben Kelly [:bkelly, not reviewing]]

James, would it be possible to add some kind of linting to catch this kind of thing in the future?  If there are known gecko-isms like `toSource()`, maybe we could just double-check they don't escape to an upstream PR.

Comment 10

[James Graham [:jgraham]]

I mean I can add a regexp; we already have one for SpecialPowers. We don't have anything as sophisticated as ESLint though.