Closed
Bug 1446285
Opened 6 years ago
Closed 6 years ago
Recent WPTs related to worker shutdown (bug 1436784) use toSource() instead of toString()
Categories
(Core :: DOM: Workers, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: baku, Assigned: baku, NeedInfo)
Details
Attachments
(1 file)
|
3.83 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8959455 -
Flags: review?(bugs)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8959455 [details] [diff] [review] toSource.patch I assume you tested this works on chrome too :) https://developer.mozilla.org/en-US/docs/Mozilla/QA/web-platform-tests#Running_tests_in_other_browsers
Attachment #8959455 -
Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fb42e9c14d4e WPT should use toString() and not toSource(), r=smaug
Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10070 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fb42e9c14d4e
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Upstream PR merged
|
||
Comment 9•6 years ago
|
||
James, would it be possible to add some kind of linting to catch this kind of thing in the future? If there are known gecko-isms like `toSource()`, maybe we could just double-check they don't escape to an upstream PR.
Flags: needinfo?(james)
|
||
Comment 10•6 years ago
|
||
I mean I can add a regexp; we already have one for SpecialPowers. We don't have anything as sophisticated as ESLint though.
Flags: needinfo?(james)
You need to log in
before you can comment on or make changes to this bug.
Description
•