1446310 - Remove CPOWs from browser_storage_updates.js

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, enhancement, P2)

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1446310 - Remove CPOWs from browser_storage_updates.js

Review commit: https://reviewboard.mozilla.org/r/228280/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228280/

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8959492 [details]
Bug 1446310 - Remove CPOWs from browser_storage_updates.js

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/228280/diff/1-2/

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8959492 [details]
Bug 1446310 - Remove CPOWs from browser_storage_updates.js

https://reviewboard.mozilla.org/r/228280/#review234214

Thanks, looks good! :)

::: devtools/server/tests/browser/browser_storage_updates.js:318
(Diff revision 2)
>    await client.close();
>    DebuggerServer.destroy();
>    finish();
>  }
>  
> -add_task(async function() {
> +async function addCookie(name, value) {

Are any of these useful helpers for other tests?  Just a thought, I have no idea!

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8959492 [details]
Bug 1446310 - Remove CPOWs from browser_storage_updates.js

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/228280/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e8de42ee46f
Remove CPOWs from browser_storage_updates.js r=jryans

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/3e8de42ee46f