1446326 - [FTL] Copy button ignore DATETIME built-in function

Status: RESOLVED DUPLICATE of bug 1437857

(Webtools Graveyard :: Pontoon, defect)

Description

[Djfe]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180310025718

Steps to reproduce:

I pressed the copy button on:
https://pontoon.mozilla.org/de/common-voice/messages.ftl/?time=201802271115-201803142224&string=175865


Actual results:

It pasted only "Effective " to the textarea below


Expected results:

The textarea should've contained the following line:
privacy-effective = Effective { DATETIME($date, month: "long", year: "numeric", day: "numeric") }

Comment 1

[Djfe]

This string doesn't even have a copy button for some reason:
https://pontoon.mozilla.org/de/common-voice/messages.ftl/?time=201802271115-201803142224&string=175940

Comment 2

[Francesco Lodolo [:flod]]

(In reply to Djfe from comment #1)
> This string doesn't even have a copy button for some reason:
> https://pontoon.mozilla.org/de/common-voice/messages.ftl/?time=201802271115-
> 201803142224&string=175940

Because it's stuck in advanced mode. See the green FTL, and notice the format

STRINGID = translation

The string is also displayed incorrectly in the sidebar, and in the history.

Comment 3

[Djfe]

I see, I saw the FTL button before, but didn't know what it was for ^^ (I'm studying the help documents of pontoon now)

Though: on this one string (only the second one I linked) pressing FTL doesn't switch to simple mode for some reason though.
it stays in FTL

Comment 4

[Francesco Lodolo [:flod]]

Doc: https://mozilla-l10n.github.io/localizer-documentation/tools/pontoon/ui.html#fluent---ftl-files

That's supposed to happen when the string has syntax issues, but this one should be correct. 

The reality is that this specific feature of Fluent wasn't used yet, and clearly Pontoon has some problems dealing with it.

P.S. I see that German has only suggestions. Are you in touch with someone to get the strings reviewed and approved?

Comment 5

[Djfe]

I'm in touch with Gregor on the Common Voice Slack currently.
He was planning to ask around the office on Monday for a german proofreader.
But that's probably not necessary anymore, since Michael Köhler just visited the project and went through all strings and approved them all :)
https://pontoon.mozilla.org/contributors/k0V4UFt5TWwQnn4xMvAosRkgFS0/

The only thing left:
I added 6 new translations after that happened, I still found some minor issues in strings I hadn't visited earlier.
I bet someone will take notice of it though. (Pontoon probably does notifications of some sort or shows people in stats that translations were added after approval, right?)

Ty for your helpful replies!

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Djfe from comment #5)
> I bet someone will take notice of it though. (Pontoon probably does
> notifications of some sort or shows people in stats that translations were
> added after approval, right?)

Unfortunately Pontoon doesn't do a good job with unreviewed suggestions on approved strings, there is a bug on file to fix that.
I've approved your most recent suggestions, hopefully I got them all.
https://github.com/mozilla/voice-web/commit/df8d930b6d0668b33e930a9df83726434b4918a9

I also realized we're abusing this bug (my fault), so I'll mark the last two comments as off-topic. Feel free to reach out to the project's person of contact if you have any questions ("contact person" in the header)
https://pontoon.mozilla.org/de/common-voice/

You can also find us around on Slack.

Comment 7

[Matjaz Horvat [:mathjazz]]

All these issues boil down to bug 1437857. Bumping its priority.

Comment 8

[Djfe]

Cool, it's fixed by now :)
I got one last question, that the documentation doesn't answer, yet
Is it allowed/correct to reorder items in the datetime function to get let's say the correct order for a date in germany?
https://pontoon.mozilla.org/de/common-voice/messages.ftl/?extra=has-suggestions&string=175865

Effective {DATETIME($date, month: "long", year: "numeric", day: "numeric")}
Gültig ab {DATETIME($date, day: "numeric", month: "long", year: "numeric")}

23.03.2018

Comment 9

[Francesco Lodolo [:flod]]

(In reply to Djfe from comment #8)
> Cool, it's fixed by now :)
> I got one last question, that the documentation doesn't answer, yet
> Is it allowed/correct to reorder items in the datetime function to get let's
> say the correct order for a date in germany?
> https://pontoon.mozilla.org/de/common-voice/messages.ftl/?extra=has-
> suggestions&string=175865
> 
> Effective {DATETIME($date, month: "long", year: "numeric", day: "numeric")}
> Gültig ab {DATETIME($date, day: "numeric", month: "long", year: "numeric")}
> 
> 23.03.2018

The order of element is irrelevant, the output depends on the current locale
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DateTimeFormat

var date = new Date(Date.UTC(2018, 03, 23, 7, 0, 0));
var options = { month: 'long', year: 'numeric', day: 'numeric' };
console.log(new Intl.DateTimeFormat('en-US', options).format(date));
// Result: April 23, 2018
console.log(new Intl.DateTimeFormat('de', options).format(date));
// Result: 23. April 2018

Comment 10

[Francesco Lodolo [:flod]]

See also
http://projectfluent.org/fluent/guide/functions.html#datetime

Comment 11

[Djfe]

Man, blazing fast support :)
Thx!!