1446332 - Remove const nsI* from tabbrowser.js

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P3)

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1446332 - Remove const nsI* from tabbrowser.js.

Review commit: https://reviewboard.mozilla.org/r/228312/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228312/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8959504 [details]
Bug 1446332 - Remove const nsI* from tabbrowser.js.

https://reviewboard.mozilla.org/r/228312/#review234126

This will have negative perf impact, but I guess it'll be very small and the readability improvement is worth it...

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6e5148a7f7d
Remove const nsI* from tabbrowser.js. r=Gijs

Comment 4

[Dão Gottwald [:dao]]

(In reply to :Gijs from comment #2)
> Comment on attachment 8959504 [details]
> Bug 1446332 - Remove const nsI* from tabbrowser.js.
> 
> https://reviewboard.mozilla.org/r/228312/#review234126
> 
> This will have negative perf impact, but I guess it'll be very small

s/very small/unmeasurably tiny/, if it exists at all. Some of the consts aren't even used multiple times.

Comment 5

[:Gijs (he/him)]

(In reply to Dão Gottwald [::dao] from comment #4)
> (In reply to :Gijs from comment #2)
> > This will have negative perf impact, but I guess it'll be very small
> 
> s/very small/unmeasurably tiny/, if it exists at all.

I've measured it, in bug 1425466, so it definitely exists. Tiny, but some of the code where there *are* multiple usages runs frequently (e.g. on docshell state changes). I don't think we should keep the previous version of this code for that impact's sake, but I think we should be aware of it in general. I'd like to come back to e.g. bug 1425616 and bug 1384727 and friends, but I'm busy with other things.

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/d6e5148a7f7d