Closed Bug 1446391 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 10075 - Add memory of last SDP offer/answer created

Categories

(Core :: WebRTC, enhancement, P4)

Product:
Core
Component:
WebRTC
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 10075 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10075
Details from upstream follow.

Harald Alvestrand wrote:
>  Add memory of last SDP offer/answer created
>  
>  This adds internal slots "LastOffer" and "LastAnswer", and uses
>  those to check that SetLocalDescription uses an unchanged SDP offer/answer.
>  
>  Bug: chromium:819629
>  Change-Id: I0c978d5ff3e63b0afab3ec02334c57a5aaa94cdd
>  Reviewed-on: https://chromium-review.googlesource.com/966441
>  WPT-Export-Revision: f0ee5086ae0ee611402b78d35d16d7e1ec167c37
Component: web-platform-tests → WebRTC
Product: Testing → Core
Ran 1 tests and 7 subtests
OK     : 1
PASS   : 3
FAIL   : 4

New tests that have failures or other problems:
/webrtc/RTCPeerConnection-setLocalDescription-offer.html
    Creating and setting offer multiple times should succeed: FAIL[linux64-stylo-disabled-debug,linux64-stylo-disabled-opt]
    Set created offer other than last offer should reject with InvalidModificationError: FAIL[linux64-stylo-disabled-debug,linux64-stylo-disabled-opt]
    setLocalDescription with type offer and null sdp should use lastOffer generated from createOffer: FAIL[linux64-stylo-disabled-debug,linux64-stylo-disabled-opt]
    setLocalDescription() with offer not created by own createOffer() should reject with InvalidModificationError: FAIL[linux64-stylo-disabled-debug,linux64-stylo-disabled-opt]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea2668153d4a
[wpt PR 10075] - Add memory of last SDP offer/answer created, a=testonly
https://hg.mozilla.org/mozilla-central/rev/ea2668153d4a
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.