Closed
Bug 1446503
Opened 6 years ago
Closed 6 years ago
Place 3 pane toggle button next to sidebar tabs in the inspector
Categories
(DevTools :: Inspector, defect, P3)
DevTools
Inspector
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Firefox 61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: mbalfanz, Assigned: gl)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
toggle-button.png
When the inspector is docked to the side, the current position of the split rule toggle feels disconnected from it's action. Instead it should be placed next to the panel tabs as left most item. Mockups at the bottom of https://mozilla.invisionapp.com/share/Z3F7OGCTK#/screens/284159829
|
Assignee | |
Updated•6 years ago
|
Priority: -- → P3
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → gl
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•6 years ago
|
Summary: Place toggle icon next to "Rules" when the inspector is docked to the side → Place 3 pane toggle button next to sidebar tabs in the inspector
| Comment hidden (mozreview-request) |
|
||
Comment 2•6 years ago
|
||
I this patch ready for review? I am not seeing any toggle button (like depicted on the mockup). Bug 1449024 should be implemented first, correct? Honza
Flags: needinfo?(gl)
|
|
Assignee | |
Comment 3•6 years ago
|
||
Sorry, you need to enable the toggle button with devtools.inspector.split-sidebar-toggle.
Flags: needinfo?(gl)
|
|
||
Comment 4•6 years ago
|
||
The attached screenshot shows what I am seeing
|
|
||
Comment 5•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8962618 [details] Bug 1446503 - Place 3 pane toggle button next to sidebar tabs in the inspector. https://reviewboard.mozilla.org/r/231472/#review238454
Attachment #8962618 -
Flags: review?(odvarko)
|
|
Assignee | |
Comment 6•6 years ago
|
||
(In reply to Jan Honza Odvarko [:Honza] from comment #4) > Created attachment 8964263 [details] > toggle-button.png > > The attached screenshot shows what I am seeing It also depends on Bug 1449024, but I think we should get Bug 1449024 reviewed again before reviewing this.
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 8•6 years ago
|
||
You will also need to reopen the toolbox after enabling the pref.
|
|
||
Comment 9•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8962618 [details] Bug 1446503 - Place 3 pane toggle button next to sidebar tabs in the inspector. https://reviewboard.mozilla.org/r/231472/#review239092 Looks good to me. R+ assuming try is green Honza
Attachment #8962618 -
Flags: review?(odvarko) → review+
|
||
Comment 10•6 years ago
|
||
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cc6cd0a77a35 Place 3 pane toggle button next to sidebar tabs in the inspector. r=Honza
|
||
Comment 11•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/cc6cd0a77a35
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•