1446503 - Place 3 pane toggle button next to sidebar tabs in the inspector

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Martin Balfanz [:mbalfanz]]

When the inspector is docked to the side, the current position of the split rule toggle feels disconnected from it's action.  Instead it should be placed next to the panel tabs as left most item.

Mockups at the bottom of https://mozilla.invisionapp.com/share/Z3F7OGCTK#/screens/284159829

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1446503 - Place 3 pane toggle button next to sidebar tabs in the inspector.

Review commit: https://reviewboard.mozilla.org/r/231472/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231472/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I this patch ready for review? I am not seeing any toggle button (like depicted on the mockup). Bug 
1449024  should be implemented first, correct?

Honza

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Sorry, you need to enable the toggle button with devtools.inspector.split-sidebar-toggle.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: toggle-button.png

The attached screenshot shows what I am seeing

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8962618 [details]
Bug 1446503 - Place 3 pane toggle button next to sidebar tabs in the inspector.

https://reviewboard.mozilla.org/r/231472/#review238454

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

(In reply to Jan Honza Odvarko [:Honza] from comment #4)
> Created attachment 8964263 [details]
> toggle-button.png
> 
> The attached screenshot shows what I am seeing

It also depends on Bug 1449024, but I think we should get Bug 1449024 reviewed again before reviewing this.

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8962618 [details]
Bug 1446503 - Place 3 pane toggle button next to sidebar tabs in the inspector.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231472/diff/1-2/

Comment 8

[Gabriel Luong [:gl] (ΦωΦ)]

You will also need to reopen the toolbox after enabling the pref.

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8962618 [details]
Bug 1446503 - Place 3 pane toggle button next to sidebar tabs in the inspector.

https://reviewboard.mozilla.org/r/231472/#review239092

Looks good to me.

R+ assuming try is green

Honza

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc6cd0a77a35
Place 3 pane toggle button next to sidebar tabs in the inspector. r=Honza

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/cc6cd0a77a35