Closed Bug 1446503 Opened 2 years ago Closed 2 years ago

Place 3 pane toggle button next to sidebar tabs in the inspector

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: mbalfanz, Assigned: gl)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

When the inspector is docked to the side, the current position of the split rule toggle feels disconnected from it's action.  Instead it should be placed next to the panel tabs as left most item.

Mockups at the bottom of https://mozilla.invisionapp.com/share/Z3F7OGCTK#/screens/284159829
Priority: -- → P3
Assignee: nobody → gl
Status: NEW → ASSIGNED
Summary: Place toggle icon next to "Rules" when the inspector is docked to the side → Place 3 pane toggle button next to sidebar tabs in the inspector
Depends on: 1449024
I this patch ready for review? I am not seeing any toggle button (like depicted on the mockup). Bug 
1449024  should be implemented first, correct?

Honza
Flags: needinfo?(gl)
Sorry, you need to enable the toggle button with devtools.inspector.split-sidebar-toggle.
Flags: needinfo?(gl)
Attached image toggle-button.png
The attached screenshot shows what I am seeing
Comment on attachment 8962618 [details]
Bug 1446503 - Place 3 pane toggle button next to sidebar tabs in the inspector.

https://reviewboard.mozilla.org/r/231472/#review238454
Attachment #8962618 - Flags: review?(odvarko)
(In reply to Jan Honza Odvarko [:Honza] from comment #4)
> Created attachment 8964263 [details]
> toggle-button.png
> 
> The attached screenshot shows what I am seeing

It also depends on Bug 1449024, but I think we should get Bug 1449024 reviewed again before reviewing this.
You will also need to reopen the toolbox after enabling the pref.
Comment on attachment 8962618 [details]
Bug 1446503 - Place 3 pane toggle button next to sidebar tabs in the inspector.

https://reviewboard.mozilla.org/r/231472/#review239092

Looks good to me.

R+ assuming try is green

Honza
Attachment #8962618 - Flags: review?(odvarko) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc6cd0a77a35
Place 3 pane toggle button next to sidebar tabs in the inspector. r=Honza
https://hg.mozilla.org/mozilla-central/rev/cc6cd0a77a35
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.