Closed Bug 1446568 Opened 6 years ago Closed 6 years ago

Move a bit more stuff from nsDocument -> nsIDocument.

Categories

(Core :: DOM: Core & HTML, enhancement)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(11 files)

Bug 1446568: Devirtualize nsIDocument::CreateElem.
59 bytes, text/x-review-board-request
smaug
: review+
Details
Bug 1446568: Move Reset and ResetToURI to nsIDocument instead of nsDocument.
59 bytes, text/x-review-board-request
smaug
: review+
Details
Bug 1446568: Remove nsDocument::UnlockPointer.
59 bytes, text/x-review-board-request
smaug
: review+
Details
Bug 1446568: Move the blocked tracking nodes methods to nsIDocument.
59 bytes, text/x-review-board-request
smaug
: review+
Details
Bug 1446568: Remove an unneeded cast.
59 bytes, text/x-review-board-request
smaug
: review+
Details
Bug 1446568: Move a few of the remaining nsDocument members to nsIDocument.
59 bytes, text/x-review-board-request
smaug
: review+
Details
Bug 1446568: Move a couple more stuff from nsDocument to nsIDocument.
59 bytes, text/x-review-board-request
smaug
: review+
Details
Bug 1446568: Make nsIDocument SetContentType / SetDocumentCharacterSet not pure virtual.
59 bytes, text/x-review-board-request
smaug
: review+
Details
Bug 1446568: Make SetScriptGlobalObject not pure virtual.
59 bytes, text/x-review-board-request
smaug
: review+
Details
Bug 1446568: Move UseCounter stuff and IsSynthesized to nsIDocument.
59 bytes, text/x-review-board-request
smaug
: review+
Details
Bug 1446568: Move a couple other methods from nsDocument to nsIDocument.
59 bytes, text/x-review-board-request
smaug
: review+
Details 
      No description provided.
Comment on attachment 8959722 [details]
Bug 1446568: Devirtualize nsIDocument::CreateElem.

https://reviewboard.mozilla.org/r/228558/#review234392

(Do I recall correctly that CreateElem actually had different implementations at some point... one in Document and one in XULDocument... oh well)
Attachment #8959722 - Flags: review?(bugs) → review+
Comment on attachment 8959723 [details]
Bug 1446568: Move Reset and ResetToURI to nsIDocument instead of nsDocument.

https://reviewboard.mozilla.org/r/228560/#review234394

ok, XULDocument does still override those.

::: dom/base/nsDocument.h
(Diff revision 1)
>    //
>    // This can be fixed after updating to rust 1.25 and updating bindgen to
>    // include https://github.com/rust-lang-nursery/rust-bindgen/pull/1271.
>    js::ExpandoAndGeneration mExpandoAndGeneration;
>  
> -  RefPtr<mozilla::EventListenerManager> mListenerManager;

Totally unrelated change, but fine.
Or perhaps tweak the commit message a bit to include also this change.
Attachment #8959723 - Flags: review?(bugs) → review+
Comment on attachment 8959724 [details]
Bug 1446568: Remove nsDocument::UnlockPointer.

https://reviewboard.mozilla.org/r/228562/#review234396

::: commit-message-2cdd8:3
(Diff revision 1)
> +Bug 1446568: Remove nsDocument::UnlockPointer. r=smaug
> +
> +And remove some now-unneeded casts.

What is this about. I see no removals
Attachment #8959724 - Flags: review?(bugs) → review+
Comment on attachment 8959724 [details]
Bug 1446568: Remove nsDocument::UnlockPointer.

https://reviewboard.mozilla.org/r/228562/#review234398

(oops, nm my comment. looks fine)
Comment on attachment 8959725 [details]
Bug 1446568: Move the blocked tracking nodes methods to nsIDocument.

https://reviewboard.mozilla.org/r/228564/#review234400
Attachment #8959725 - Flags: review?(bugs) → review+
Comment on attachment 8959726 [details]
Bug 1446568: Remove an unneeded cast.

https://reviewboard.mozilla.org/r/228566/#review234402
Attachment #8959726 - Flags: review?(bugs) → review+
Comment on attachment 8959727 [details]
Bug 1446568: Move a few of the remaining nsDocument members to nsIDocument.

https://reviewboard.mozilla.org/r/228568/#review234404
Attachment #8959727 - Flags: review?(bugs) → review+
Comment on attachment 8959728 [details]
Bug 1446568: Move a couple more stuff from nsDocument to nsIDocument.

https://reviewboard.mozilla.org/r/228570/#review234406
Attachment #8959728 - Flags: review?(bugs) → review+
Comment on attachment 8959729 [details]
Bug 1446568: Make nsIDocument SetContentType / SetDocumentCharacterSet not pure virtual.

https://reviewboard.mozilla.org/r/228572/#review234408

::: dom/base/nsIDocument.h:791
(Diff revision 1)
>      return mCharacterSet;
>    }
>  
>    /**
> -   * Set the document's character encoding.
> +   * Set the document's character encoding. This will
> +   * trigger a startDocumentLoad if necessary to answer the question.

Looks like the comment in nsDocument.h is wrong, so stick with the comment nsIDocument.h already has
Attachment #8959729 - Flags: review?(bugs) → review+
Comment on attachment 8959730 [details]
Bug 1446568: Make SetScriptGlobalObject not pure virtual.

https://reviewboard.mozilla.org/r/228574/#review234410
Attachment #8959730 - Flags: review?(bugs) → review+
Comment on attachment 8959731 [details]
Bug 1446568: Move UseCounter stuff and IsSynthesized to nsIDocument.

https://reviewboard.mozilla.org/r/228576/#review234412
Attachment #8959731 - Flags: review?(bugs) → review+
Comment on attachment 8959732 [details]
Bug 1446568: Move a couple other methods from nsDocument to nsIDocument.

https://reviewboard.mozilla.org/r/228578/#review234414
Attachment #8959732 - Flags: review?(bugs) → review+
Comment on attachment 8959723 [details]
Bug 1446568: Move Reset and ResetToURI to nsIDocument instead of nsDocument.

https://reviewboard.mozilla.org/r/228560/#review234432

::: dom/base/nsDocument.h
(Diff revision 1)
>    //
>    // This can be fixed after updating to rust 1.25 and updating bindgen to
>    // include https://github.com/rust-lang-nursery/rust-bindgen/pull/1271.
>    js::ExpandoAndGeneration mExpandoAndGeneration;
>  
> -  RefPtr<mozilla::EventListenerManager> mListenerManager;

Yeah, this is used by ResetToURI, so it's needed. Will mention it in the commit message.
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71288e94a4e4
Devirtualize nsIDocument::CreateElem. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/de1ebfe4f5b9
Move Reset and ResetToURI to nsIDocument instead of nsDocument. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/339d892ddf7f
Remove nsDocument::UnlockPointer. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/20d621bd59d5
Move the blocked tracking nodes methods to nsIDocument. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc8a03f7e15e
Remove an unneeded cast. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0387ea3bdff
Move a few of the remaining nsDocument members to nsIDocument. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6dec081f644
Move a couple more stuff from nsDocument to nsIDocument. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/0740c8e6d169
Make nsIDocument SetContentType / SetDocumentCharacterSet not pure virtual. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f3e5bc6ac99
Make SetScriptGlobalObject not pure virtual. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d7210ef8a29
Move UseCounter stuff and IsSynthesized to nsIDocument. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/3508bdff5806
Move a couple other methods from nsDocument to nsIDocument. r=smaug
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: