1446619 - there is a line in top of tabbar when using multiple monitors

Status: NEW

(Core :: Widget: Win32, defect, P3)

Description

[Hossein Mortazavi]

Attachment: Capture3.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180315233128

Steps to reproduce:

having multiple monitors with different resolution


Actual results:

there's an additional line on top of tab bad and bottom of Firefox about page.


Expected results:

there should be no additional line and should be like my primary monitor.

Comment 1

[Hossein Mortazavi]

Attachment: Screenshot (2).jpg

Comment 2

[Carmen Fat [:cfat] - Ecosystem QA]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0

Hi ho.morf, thanks for reporting this issue.

I wasn't able to reproduce the issue on Windows 10 x64, using latest Nightly 61.0a1 (2018-03-21) and Firefox Release 59.0.1. 
I've set the following values for the monitors:
- monitor 1: 1280 x 600
- monitor 2: 1440 x 900

After setting the custom values for resolution, I've opened the about Firefox window and moved it from a monitor to each other. I've done the same thing with the Firefox window but didn't didn't manage to reproduce the issue you describe.

Can you please give me the values you set for your monitors while you reproduce the issue?

Thanks.

Comment 3

[Hossein Mortazavi]

My first monitor resolution is 3840 x 2160p and my second monitor is 1920 x 1080p and for reproducing the issue you should open Firefox in your second monitor and not in your first one and then move it to your second monitor. If you run Firefox in your second monitor i.e. my lower resolution monitor and open about window moving it to the first monitor doesn't eliminate the bottom white bar.

Comment 4

[Carmen Fat [:cfat] - Ecosystem QA]

Tested again using the following resolutions available: 3840 x 2160 and 1680 x 1050 and managed to reproduce only the blank space from the bottom of "abour Firefox" window. I didn't notice any similar blank space at the top of the tab strip. 

This was reproducible only with Firefox Release 59.0.2 on my side. Can you please retest this with Firefox Nightly and report back the results? You can download the latest Nightly build from here https://goo.gl/57dpxn.

Thanks.

Comment 5

[Hossein Mortazavi]

I reproduced the issue on nightly version either. I'll upload the screenshot.

Comment 6

[Hossein Mortazavi]

Attachment: Capture5.PNG

Comment 7

[Hossein Mortazavi]

Attachment: Capture5.PNG

Comment 8

[Hossein Mortazavi]

I have the 62 version and this bug is not resolved isn't there anyone to solve this issue??!!!

Comment 9

[Carmen Fat [:cfat] - Ecosystem QA]

Unfortunately, I don't have any updates regarding the progress of this issue.
Sean, is there something we can do about this behavior?

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Why is this on Layout: view rendering even?

Does this only reproduce on Windows?

Comment 11

[Sean Voisen (:svoisen)]

Yes, pretty sure this is miscategorized. Should probably go in Core > Window Management. Will move.

Comment 12

[Hossein Mortazavi]

I'm now using version 63 b9 but the problem persists. Guys please do something about it after all the months passed the submission date!

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Hey Neil (or timdream), can you please triage this ASAP?

Comment 14

[Mike Conley (:mconley) (:⚙️)]

See comment 2

Comment 15

[Mike Conley (:mconley) (:⚙️)]

(ni?ing timdream, see comment 13)

Comment 16

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Is this a regression of Fx59? Is it possible to identify the regressed bug?

Comment 17

[Mike Conley (:mconley) (:⚙️)]

Hey Ovidiu, is there anybody over in your lab who can help trying to reproduce this and finding a regression window? We're having no luck over here.

Comment 18

[keyset]

I am experiencing this problem as well, and one detail that's missing from this bug but mentioned elsewhere (reddit thread, mozilla support) is the scaling setting is different on the monitors. For example, my primary monitor is 2880x1800 scaled to 150% while my external monitor is 1920x1080 scaled to 100%. If I change the scaling on the external monitor to 150% to match the primary, the problem goes away.

Mozilla Support forum: https://support.mozilla.org/en-US/questions/1236711
Reddit thread: https://www.reddit.com/r/firefox/comments/8fomdk/cant_click_the_very_top_of_tabs_after_getting_a/

Comment 19

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have managed to reproduce this issue on Firefox 62.0.3 release. During testing of different versions of Firefox I have observed that there are two separate issues:
1. One of them is the white border displayed at the top of the Firefox window if you have two monitors with different resolution. But this issue is only reproducible on my side if I set the Light theme from "about:addons" at "Themes" section.
2. The other one is the white border displayed at the bottom of the "About Firefox" window.

It seems that the first issue (white border at the top of the Firefox window) is no longer reproducible on latest Nightly (64.0a1) build. Using the mozregression tools I have found the bug which fixed it:
Pushlog: https://goo.gl/q5a15g
From this pushlog it seems that bug 1302168 fixed the issue.

The second issue (white border displayed at the bottom of the "About Firefox" window, seems to be an old regression. The issue is not reproducible on Nightly 47.0a1 build. 
Using the mozregression tools I have got a pushlog: https://goo.gl/hqpr9b
Unfortunately, I didn't manage to go further since there are very old builds. So probably one of the issues from the pushlog introduced this.

@ho.morf can you please verify if the first issue (white border at the top of the Firefox window) is fixed on latest Nightly (64.a01) build?

Comment 20

[Hossein Mortazavi]

the number one issue is reproducible in every theme in FF63 although it is more distinctive in white theme
I installed FF nightly and the line on top of the tab bar is gone but the second issue still persists (the line in about window).
I'll upload some photos

Comment 21

[Hossein Mortazavi]

Attachment: Annotation (6).png

Comment 22

[Hossein Mortazavi]

Attachment: Annotation (7).png

Comment 23

[Hossein Mortazavi]

Attachment: Annotation (8).png

Comment 24

[Neil Deakin]

When I investigated the about dialog issue, I notice that when the dialog is moved to the other screen, the outer rectangle of the window remains correct, but the inner window size is different by a few pixels, accounting for the white bar.

When this window is moved to the other screen, the window is resized via nsWindow::Resize to the correct size (adjusting for the scaling). Within nsWindow::Resize, the correct height is passed to SetWindowPos, but if I add a call just afterwards to GetClientRect the rectangle is a few pixels off of what it should be, by the same amount as the white bar height.

It appears that the titlebar/border of the window is being adjusted by a different scale than the client part of the window, so something needs to account for this variation.

Sometimes, moving the dialog between screens causes a huge size change but I didn't investigate that.

Anyway, I think this is a Windows-only sizing issue so I'm going to move the bug there.

Comment 25

[cyraid]

I am also having this issue as I commented in #1496778. There is a line on the left, bottom, and right (1px white line?), but the top seems to be aligned correctly. This is on a monitor that has 125% scale, the maximized window on the monitor with 100% scale looks correct.

Comment 26

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.