1446627 - Remove the overlays of am-identity-edit.xul and insert it's content directly or through includes

Status: RESOLVED FIXED

(MailNews Core :: Account Manager, enhancement)

Description

[Richard Marti (:Paenglab)]

The am-identity-edit.xul has overlays we can remove through inlining and preprocessing.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: am-identity-edit.patch

The am-identity-edit.xul isn't the only which used this overlays, so I alsotreated the same to the other files.

Comment 2

[:aceman]

Comment on attachment 8959790 [details] [diff] [review]
am-identity-edit.patch

Review of attachment 8959790 [details] [diff] [review]:
-----------------------------------------------------------------

Great, more files get pre-processing that didn't have it before. That slows down development :(
Thanks for the patch.

::: mailnews/base/prefs/content/am-identity-edit.xul
@@ +61,5 @@
>      <tabs id="identitySettings">
>        <tab label="&settingsTab.label;"/>
>        <tab label="&copiesFoldersTab.label;"/>
>        <tab label="&addressingTab.label;"/>
> +      <tab label="&securityTab.label;"/>

And we can see the ugliness of the preprocessing instead of xul overlay. Here the label and the scripts above are ripped out of extensions/smime/content/am-smime.inc file and need to be duplicated at all callers. So the features are no longer logically grouped in a single file.

Comment 3

[Richard Marti (:Paenglab)]

Yes, and the size grows because the code is no more in only one file that overlays the other but in every one that was overlayed.

Comment 4

[Richard Marti (:Paenglab)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=96757685e0b37198bf68a6663895d3c71964be2d

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c7f944624807
Remove the overlays of am-identity-edit.xul and insert its content directly or through includes. r=aceman