Closed
Bug 1446648
Opened 6 years ago
Closed 6 years ago
Web Replay: Record refcount changes on various classes
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
INVALID
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | affected |
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(2 files)
|
7.07 KB,
patch
|
Details | Diff | Splinter Review | |
|
698 bytes,
patch
|
Details | Diff | Splinter Review |
While testing, I've noticed that the thread which releases the last reference on this class can vary within the same recording, leading to mismatches with the recording when the destructor performs recorded operations. This happens because refcount changes are not recorded by default. The attached patch records refcount changes for nsPipeInputStream, makes changes to nsISupportsImpl.h so that using a recorded refcount is a one line change, and uses this to revert earlier changes to allow recording Runnable refcounts.
|
Assignee | |
Comment 1•6 years ago
|
||
https://hg.mozilla.org/projects/ash/rev/9e9c879d7873b5324f80712d3c6b22aa84b91a7c
|
|
Assignee | |
Comment 2•6 years ago
|
||
AbstractThread has similar issues.
|
|
Assignee | |
Updated•6 years ago
|
Summary: Web Replay: Record refcount changes on nsPipeInputStream → Web Replay: Record refcount changes on various classes
|
|
Assignee | |
Comment 3•6 years ago
|
||
https://hg.mozilla.org/projects/ash/rev/081bd3cdee1dcf6d613963ec06e74fdee7f073f7
|
|
Assignee | |
Comment 4•6 years ago
|
||
Closing this bug, all the changes here will be reviewed in separate bugs dependent on bug 1422587.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•