1446680 - bustage at WindowsDllBlocklist.cpp(868): error C2065: 'gStartAddressesToBlock': undeclared identifier when Gecko 61 merges to Beta on 2018-04-26

Status: VERIFIED FIXED

(Core :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b12ef97b1b8da8b50098088781dfa7770f17809&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=168682553
The Windows build jobs are busted from the changes in bug 1435816 because an ifdef NIGHTLY_BUILD is missing.

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=168682553&repo=try

z:/build/build/src/mozglue/build/WindowsDllBlocklist.cpp(868): error C2065: 'gStartAddressesToBlock': undeclared identifier

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1446680 - Restrict WindowsDllBlocklist's gStartAddressesToBlock to Nightly builds.

Review commit: https://reviewboard.mozilla.org/r/228638/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228638/

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=24993bf81d08b875fe180ece22e235f872c77fcd

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8959869 [details]
Bug 1446680 - Restrict WindowsDllBlocklist's gStartAddressesToBlock to Nightly builds.

https://reviewboard.mozilla.org/r/228638/#review234444

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/023918b79066
Restrict WindowsDllBlocklist's gStartAddressesToBlock to Nightly builds. r=aklotz

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/023918b79066

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b01463adc3d463336d837c987bca01fbf5afb6a&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&group_state=expanded