1446722 - Onchange-event not triggered when resetting non-focused date-input-field (same for time-input-field)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Gabriel Gritsch]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/604.5.6 (KHTML, like Gecko) Version/11.0.3 Safari/604.5.6

Steps to reproduce:

Clicked on the "x"-button of a date-input-field (that was not focused) to reset the date.
Clicked on the "x"-button of a time-input-field (that was not focused) to reset the date.

Both works fine if the field has focus (blue border).


Actual results:

The onchange-event is NOT fired.


Expected results:

The onchange-event should have been fired.

Comment 1

[u554753]

Hi Gabriel, thanks for reporting the issue.

What websites were you visiting where you can replicate this issue?

Comment 2

[Gabriel Gritsch]

no website needed.
you can replicate it with every <input type="date" onchange="alert('changed');" />

Gabriel

Comment 3

[Henri Sivonen (:hsivonen)]

I see an alert when following the steps to reproduce on
data:text/html;charset=utf-8,<input type="date" onchange="alert('changed');" />

Comment 4

[Gabriel Gritsch]

With what version on what system?

Thank you

(In reply to Henri Sivonen (:hsivonen) from comment #3)
> I see an alert when following the steps to reproduce on
> data:text/html;charset=utf-8,<input type="date" onchange="alert('changed');"
> />

Comment 5

[Henri Sivonen (:hsivonen)]

(In reply to Gabriel Gritsch from comment #4)
> With what version on what system?

61.0a1 (2018-04-27) 64-bit on Ubuntu 16.04.

Comment 6

[Gabriel Gritsch]

Hi,

its still reproducible, but I found out when it is reproducible with version 60.0:
it does NOT work if a value is preset when the page is loaded and you click on the "reset"-button.

You can test it with the code on that page:

https://www.gritsch-soft.com/ff/date.html

I have also created a short screencast to show the error:

https://ufile.io/itzau (link valid for 30 days).

Comment 7

[Nika Layzell [:nika] (ni? for response)]

I cannot reproduce this on Nightly 62

Comment 8

[Gabriel Gritsch]

Sorry but I have to re-open it.
It is still reproducible on Nightly 62.0a1 (2018-05-26) on macOS 10.13.4 (not tested on other Systems).

Comment 9

[Guillaume .J]

I just camed here because i encoutered the exact same issue.

I'll attach this issue a html test case. The input[date] have a default value and as you can see in the console if you clic the reset buton right after the page load the onChange event is not triggered. However if the input get the focus and then the reset buton trigger the onChange event.

The expected behavior is that no matter what the input have the focus or not if his value change then the onChange event should be triggered.

Comment 10

[Guillaume .J]

Attachment: testcase.html

Comment 11

[janni.squall]

Can confirm i run into the same problem.
The Bug only appers
1. On a fresh request (because F5 and Strg+R let the predefined value disappear)
2. if the first interaction with the date field is the click on the X Icon (Once the date field get the focus, it works)
3. the value param is set (If no value is set the X Icon does not appear)

Test Code:
<input type="date" onchange="alert('changed')" value="2018-09-09" /> 

Environment: Firefox Quantum 62.0.3 (64-Bit), Ubuntu 18.04

Comment 12

[Asaf Gartner]

I can reproduce this bug on Firefox Quantum 64b4 (64bit), Windows 10.

Comment 13

[Gabriel Gritsch]

Still no fix?

Comment 16

[nagarjunbn8]

this issue is not resolved from almost an year.😤

Comment 17

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1446722: set default value for 'mFocusedValue' for the html input elements 'date' and 'time'.

In order to trigger the 'onchange' event when resetting the 'date' or
'time' html input elements.

This review is only basis for discussion in order to determine if the
fix goes in the correct direction.

Comment 18

[Mirko Brodesser (:mbrodesser-Igalia)]

:smaug: can you please have a look at the attached review (https://bugzilla.mozilla.org/attachment.cgi?id=9051306). It is just a first version, reflecting my current understanding of the code. I'm interested if the fix is going in the correct direction. Any feedback is appreciated.

Comment 19

[Olli Pettay [:smaug][[e-mail]]]

Took a bit time to figure out that stuff, but looks reasonable.
Store the initial value early so that we can compare later when value is set to "";

Comment 20

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1446722: set default value for 'mFocusedValue' for the html input elements 'date' and 'time'.

In order to trigger the 'onchange' event when resetting the 'date' or
'time' html input elements.

Comment 21

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1446722: set default value for 'mFocusedValue' for the html input elements 'date' and 'time'.

In order to trigger the 'onchange' event when resetting the 'date' or
'time' html input elements.

Comment 22

[Mirko Brodesser (:mbrodesser-Igalia)]

The try run (https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb92b88e86520088bd63f140da4f19d0afcf0849,) for the attached patch looks OK. It contains a few failures, but they are not related to this change.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98343ff41322
set default value for 'mFocusedValue' for the html input elements 'date' and 'time'. r=smaug

Comment 24

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/98343ff41322