1446816 - add back KEY to the list of artifacts that is uploaded for each release

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, enhancement, P1)

Description

[Mihai Tabara [:mtabara]⌚️GMT]

After rewriting checksums in Taskcluster in bug 1432219, we no longer have this file uploaded along within the rest of artifacts for the `~candidates` dirs. Let's add this back. 

Solutions:
* either add it to the signingscript so that is dumped along with the files and grabbed by beetmover
* add it in-tree and place it directly under artifacts for any of the `release-bouncer` tasks

Comment 1

[[e-mail] (:bhearsum)]

Attachment: add KEY file to signing scriptworker deployment

I haven't tested this yet (do you have any pointers on doing that?), but it seems plausible.

Comment 2

[Phabricator Automation]

Attachment: Add KEY file to artifacts list.

Comment 3

[Aki Sasaki (not active)]

Comment on attachment 8964675 [details] [diff] [review]
add KEY file to signing scriptworker deployment

I don't know of a great way to test other than setting up a puppet env on releng-puppet2, and pointing the beetmover-dev pool at it. Then we could test a staging release on maple, and (assuming we have KEY in a beetmover upstreamArtifacts somewhere) we'll have KEY in the staging bucket candidates dir.

If we're pretty confident in this, we can roll this out to prod puppet and watch for puppet errors in email, and roll back if we hit any issues. It's still wise to test on maple after this is rolled out.

Comment 4

[Phabricator Automation]

Comment on attachment 8964676 [details]
Add KEY file to artifacts list.

Aki Sasaki [:aki] has approved the revision.

https://phabricator.services.mozilla.com/D840

Comment 5

[[e-mail] (:bhearsum)]

I had to make some minor fixes, but this worked in staging. You can see the KEY file present in both candidates and releases:
http://ftp.stage.mozaws.net/pub/firefox/candidates/59.0b20-candidates/build7/
http://ftp.stage.mozaws.net/pub/firefox/releases/59.0b20/

I'll provide updated patches shortly, and then we can get this landed + backported.

Comment 6

[[e-mail] (:bhearsum)]

Attachment: syntax + path fixes

The KEY locations were inconsistent in the earlier patch, and I missed a couple of commas.

Comment 7

[[e-mail] (:bhearsum)]

Attachment: upgrade beetmoverworker and signing scriptworker versions

This shouldn't land until https://github.com/mozilla-releng/signingscript/pull/48 and https://github.com/mozilla-releng/beetmoverscript/pull/114 are merged, and new tarballs are on the puppet server.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ade4a1adeba
add back KEY to the list of artifacts that is uploaded for each release. r=aki

Comment 9

[[e-mail] (:bhearsum)]

Also landed on beta:
https://hg.mozilla.org/releases/mozilla-beta/rev/1564bef7385394af80874bd0dc976af43085fa66

This will get used in b11 next week.

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5ade4a1adeba

Comment 11

[Phabricator Automation]

Attachment: Bug 1446816: Add KEY files to production Thunderbird signing scriptworker; r?aki

Comment 12

[Phabricator Automation]

Comment on attachment 8969686 [details]
Bug 1446816: Add KEY files to production Thunderbird signing scriptworker; r?aki

Aki Sasaki [:aki] has approved the revision.

https://phabricator.services.mozilla.com/D1005