1446861 - Remove more nsIDOMElement usages from editor

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Makoto Kato [:m_kato]]

Except to table access and XPCOM method for c-c, we can remove more nsIDOMElement  usages.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1446861 - Remove more nsIDOMElement usages from editor.

Except to table access and XPCOM methods for c-c, tests and etc, we can remove
more nsIDOMElement usages to avoid QI.

Review commit: https://reviewboard.mozilla.org/r/228850/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228850/

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8960071 [details]
Bug 1446861 - Remove more nsIDOMElement usages from editor.

https://reviewboard.mozilla.org/r/228850/#review234518

::: commit-message-0b997:3
(Diff revision 1)
> +Bug 1446861 - Remove more nsIDOMElement usages from editor. r?masayuki
> +
> +Except to table access and XPCOM methods for c-c, tests and etc, we can remove

s/Except to/Except ?

::: editor/libeditor/EditorEventListener.cpp:1105
(Diff revision 1)
>      // listener in the chain changed the focus.
>      if (editableRoot) {
> -      nsIFocusManager* fm = nsFocusManager::GetFocusManager();
> +      nsFocusManager* fm = nsFocusManager::GetFocusManager();
>        NS_ENSURE_TRUE(fm, NS_OK);
>  
> -      nsCOMPtr<nsIDOMElement> element;
> +      nsCOMPtr<nsIContent> focusedContent = fm->GetFocusedContent();

Looks like that this can be nsIContent* since FindFirstNonChromeOnlyAccessContent() is safe to call without grabbing it.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/60d8158308b2
Remove more nsIDOMElement usages from editor. r=masayuki

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/60d8158308b2