1446912 - Custom new tab pages make "restore closed tab" less good

Status: UNCONFIRMED

(WebExtensions :: General, defect, P3)

Description

[Geoffrey De Belie (Smile4ever)]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180316100132

Steps to reproduce:

* Open 4 tabs: Google, Wikipedia and 2 new tabs while having an extension as Tabliss installed - https://addons.mozilla.org/en-US/firefox/addon/tabliss/
* Close the Wikipedia tab.
* Close one "new" tab (in this case, Tabliss).
* Press CTRL+SHIFT+T (restore closed tab)


Actual results:

The page of Tabliss is opened again. 


Expected results:

Tabliss tab should be treated as a "new tab", not as a tab that needs to be restored.

With about:newtab, the behaviour is not to reopen "new tabs" and instead it would reopen the Wikipedia tab. This behaviour can be observed when Tabliss (or any other addon that customises the new tab page) is not installed.

Comment 1

[Geoffrey De Belie (Smile4ever)]

See also https://github.com/joelshepherd/tabliss/issues/17

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

I just briefly checked the extension manifest to verify how the "new tab" is being overridden by this extension, and I confirm that it uses the "chrome_url_overrides.newtab property" (as well as the "chrome_settings_overrides.homepage" which overrides the url loaded when the home icon is clicked):

https://github.com/joelshepherd/tabliss/blob/5a3c6e9bc9c5e141b41934de56754119edee9de6/src/manifest_firefox.json#L13-L18

Comment 3

[Andrew Swan [:aswan]]

Luca offered to take a look

Comment 4

[Firefox Bug Husbandry Bot]

Bulk move of bugs per https://bugzilla.mozilla.org/show_bug.cgi?id=1483958